Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the flux2-sync helm chart in the examples. #636

Merged
merged 1 commit into from Apr 8, 2024
Merged

Using the flux2-sync helm chart in the examples. #636

merged 1 commit into from Apr 8, 2024

Conversation

swade1987
Copy link
Member

No description provided.

@swade1987 swade1987 force-pushed the fix-helm-chart-example branch 2 times, most recently from 9b1e257 to ea4487a Compare April 8, 2024 14:51
@swade1987
Copy link
Member Author

@stefanprodan could you please set the required tests to be the following now moving forward please

  • tests / e2e-helm-install-with-github
  • tests / e2e-flux-bootstrap-with-github

stefanprodan
stefanprodan reviewed Apr 8, 2024
View reviewed changes
examples/helm-install/main.tf Outdated Show resolved Hide resolved
examples/helm-install/main.tf Outdated Show resolved Hide resolved
examples/helm-install/main.tf Outdated Show resolved Hide resolved
examples/helm-install/main.tf Outdated Show resolved Hide resolved
@stefanprodan
Copy link
Member

@swade1987 e2e tests can't be required as they don't run on forks.

@swade1987
Copy link
Member Author

swade1987 commented Apr 8, 2024 •
edited

@swade1987 e2e tests can't be required as they don't run on forks.

@stefanprodan I meant for the main branch as I have changed the name of the flux-bootstrap one in this PR.

stefanprodan
stefanprodan reviewed Apr 8, 2024
View reviewed changes
examples/helm-install/main.tf Outdated Show resolved Hide resolved
.github/workflows/tests.yaml Show resolved Hide resolved
.github/workflows/tests.yaml Outdated Show resolved Hide resolved
@swade1987
Updating helm-chart example to include flux2-sync chart.
a046975 
Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
@stefanprodan stefanprodan added the area/testing Testing related issues and pull requests label Apr 8, 2024
stefanprodan
stefanprodan approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @swade1987 🏅

@stefanprodan stefanprodan merged commit 2ff91d4 into fluxcd:main Apr 8, 2024
18 checks passed
@swade1987 swade1987 deleted the fix-helm-chart-example branch April 8, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/testing Testing related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@swade1987 @stefanprodan