Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): Adding example of managing the flux ssh keypair in terraform. #647

Merged
merged 1 commit into from Apr 9, 2024
Merged

feat(docs): Adding example of managing the flux ssh keypair in terraform. #647

merged 1 commit into from Apr 9, 2024

Conversation

swade1987
Copy link
Member

@swade1987 swade1987 commented Apr 9, 2024 •
edited

Description

Adds an example showing how to manage the SSH keypair flux uses in Terraform for easier rotation.

Motivation and Context

Fixes #646
Discussed in #596

How has this been tested?

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the documentation (if required) with make docs

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritise this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

stefanprodan
stefanprodan reviewed Apr 9, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
examples/github-self-managed-ssh-keypair/README.md Outdated Show resolved Hide resolved
@swade1987 swade1987 force-pushed the github-self-managed-ssh-keypair branch from 4926d2e to d4b88b0 Compare April 9, 2024 12:07
@stefanprodan stefanprodan added the area/docs Documentation related issues and pull requests label Apr 9, 2024
@swade1987
feat(docs): Adding example of managing the flux ssh keypair in terraf…
d652937 
…orm.

Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
@swade1987 swade1987 force-pushed the github-self-managed-ssh-keypair branch from d30cfb2 to d652937 Compare April 9, 2024 12:17
stefanprodan
stefanprodan approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @swade1987

@stefanprodan stefanprodan merged commit 99e2d07 into fluxcd:main Apr 9, 2024
21 checks passed
@swade1987 swade1987 deleted the github-self-managed-ssh-keypair branch April 9, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/docs Documentation related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Repo]: Add a Terraform example for self managing SSH keypair
2 participants
@swade1987 @stefanprodan