Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding optional git manifest delete. #650

Merged
merged 1 commit into from Apr 10, 2024

Conversation

swade1987
Copy link
Member

@swade1987 swade1987 commented Apr 10, 2024

Description

Allows you to choose whether or not to delete the git optionally manifests when executing terraform destroy

Motivation and Context

Fixes #649

How has this been tested?

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the documentation (if required) with make docs

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritise this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Co-authored-by: Dmitriy Chumalo <140all@mail.ru>
Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
@stefanprodan stefanprodan added the enhancement New feature or request label Apr 10, 2024
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @swade1987 🥇

@stefanprodan stefanprodan merged commit c79bdac into fluxcd:main Apr 10, 2024
11 checks passed
@swade1987 swade1987 deleted the skip-manifest-delete branch April 10, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Optionally delete manifests from Git on "terraform destroy"
2 participants