Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an option not to delete the namespace flux is installed into. #657

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Provide an option not to delete the namespace flux is installed into. #657

merged 1 commit into from
Apr 13, 2024

Conversation

swade1987
Copy link
Member

@swade1987 swade1987 commented Apr 12, 2024 •
edited

Description

It provides an option not to delete the namespace flux is installed into.

Motivation and Context

Fixes #654

How has this been tested?

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the documentation (if required) with make docs

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritise this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@swade1987 swade1987 changed the title Providing option to not delete namespace flux is installed into. Provide an option not to delete the namespace flux is installed into. Apr 12, 2024
@swade1987 swade1987 force-pushed the keep-namespace branch 3 times, most recently from d9f976a to 8ae6866 Compare April 12, 2024 21:52
@swade1987
Providing option to not delete namespace flux is installed into.
ebf4be7 
Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
@stefanprodan stefanprodan added the area/kubernetes Kubernetes bootstrap related issues and pull requests label Apr 13, 2024
stefanprodan
stefanprodan approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @swade1987 馃

@stefanprodan stefanprodan merged commit 7b130fb into fluxcd:main Apr 13, 2024
11 checks passed
@stefanprodan stefanprodan mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/kubernetes Kubernetes bootstrap related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Provider should not delete namespace if it did not create it
2 participants
@swade1987 @stefanprodan