Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTofu min supported version to readme #687

Merged
merged 1 commit into from May 7, 2024
Merged

Add OpenTofu min supported version to readme #687

merged 1 commit into from May 7, 2024

Conversation

swade1987
Copy link
Member

@swade1987 swade1987 commented May 7, 2024

Description

I have manually validated the examples work with OpenTofu version 1.7.0 (latest)

Motivation and Context

Fixes #683

How has this been tested?

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc

...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the documentation (if required) with make docs

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritise this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@swade1987 swade1987 force-pushed the opentofu branch 2 times, most recently from 60a2ae1 to 7853574 Compare May 7, 2024 13:33
@stefanprodan stefanprodan changed the title Adding opentofu support. Add OpenTofu min supported version to readme May 7, 2024
@stefanprodan
Copy link
Member

Please rename the commit to the PR title and remove all changes except for the readme ones.

@swade1987
Copy link
Member Author

Can I propose we leave the CI job name changes as they are pretty useful.

@stefanprodan
Copy link
Member

Can I propose we leave the CI job name changes as they are pretty useful.

But they are not related to OpenTofu, let's keep this PR scoped to what it suppose to do.

Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
@stefanprodan stefanprodan added the area/docs Documentation related issues and pull requests label May 7, 2024
@swade1987 swade1987 merged commit 99809d0 into main May 7, 2024
7 checks passed
@swade1987 swade1987 deleted the opentofu branch May 7, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Repo]: List OpenTofu support
2 participants