Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding registry credential support to bootstrap resource. #688

Merged
merged 1 commit into from May 13, 2024

Conversation

swade1987
Copy link
Member

@swade1987 swade1987 commented May 9, 2024

Description

Allows the user to provide registry credentials in the form username: password

Motivation and Context

Fixes #635
Leverages upstream fluxcd/flux2 PR: https://github.com/fluxcd/flux2/pull/4706/files

How has this been tested?

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc

...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the documentation (if required) with make docs

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritise this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@swade1987 swade1987 changed the title WIP: Adding registry credential support to bootstrap resource. Adding registry credential support to bootstrap resource. May 9, 2024
@stefanprodan stefanprodan added the hold Issues and pull requests put on hold label May 9, 2024
@stefanprodan
Copy link
Member

Thanks @swade1987 I've put this on hold, needs to be rebased after Flux 2.3.0 is released.

@swade1987 swade1987 force-pushed the registry-auth branch 2 times, most recently from 4825f5e to 3ced5e2 Compare May 9, 2024 16:58
Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
@stefanprodan stefanprodan added enhancement New feature or request and removed hold Issues and pull requests put on hold labels May 13, 2024
@stefanprodan stefanprodan merged commit cb27fda into main May 13, 2024
8 checks passed
@stefanprodan stefanprodan deleted the registry-auth branch May 13, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add registry_creds attribute to bootstrap git resource
2 participants