Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux completion powershell - Missing "powershell" in commands #1347

Closed
javiermarasco opened this issue Jan 5, 2023 · 2 comments · Fixed by fluxcd/flux2#3465
Closed

flux completion powershell - Missing "powershell" in commands #1347

javiermarasco opened this issue Jan 5, 2023 · 2 comments · Fixed by fluxcd/flux2#3465

Comments

@javiermarasco
Copy link

In the documentation there is a missing part, the documentation states:

Windows:

cd "$env:USERPROFILE\Documents\WindowsPowerShell\Modules"
flux completion >> flux-completion.ps1

Linux:

cd "${XDG_CONFIG_HOME:-"$HOME/.config/"}/powershell/modules"
flux completion >> flux-completions.ps1
Options 

While the flux completion command should be flux completion powershell.

Text should read:

Windows:

cd "$env:USERPROFILE\Documents\WindowsPowerShell\Modules"
flux completion powershell >> flux-completion.ps1

Linux:

cd "${XDG_CONFIG_HOME:-"$HOME/.config/"}/powershell/modules"
flux completion powershell >> flux-completions.ps1
Options 
kingdonb pushed a commit to kingdonb/flux2 that referenced this issue Jan 6, 2023
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
@kingdonb
Copy link
Member

kingdonb commented Jan 6, 2023

Please have a look at

Does this look like what you're suggesting?

@javiermarasco
Copy link
Author

Hi @kingdonb that is correct! thank you! 🎉👍

raffis pushed a commit to raffis/flux2 that referenced this issue Jan 10, 2023
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
souleb pushed a commit to souleb/flux2 that referenced this issue Jul 10, 2023
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants