-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flux Website Resource Page Update #1693
Conversation
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
@kingdonb Please feel free to review |
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Thanks! I have this on my radar, I see you're ready! We've got the KubeCon Paris CFP deadline coming up in two days, and then we'll be more available for PR reviews. It looks like you have completed the work based on the checklist ✅ Assigning myself so this gets kept track of! |
Signed-off-by: thisisobate <obasiuche62@gmail.com>
@kingdonb I have fixed all the issues you mentioned above. |
I think this can be done by the community as a follow-up PR. cc: @kingdonb |
We've just had another chance to review this, it looks like all the corrections you made are good! I'm happy to approve this. (Will be rebasing before merge) |
LGTM - Only tiny thing I'd mention is handling EOL at EOF which can be easily fixed in your IDE settings. |
I'm going to reopen this, I cannot merge it by myself and I cannot edit your branch, but I've rebased the commits and merged it with #1748 that created the conflict |
Reopened as #1749 (Will be likely merged as soon as I have an approving review from another maintainer with write access!) |
Fixes cncf/techdocs#192
Todos