Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makie 0.17 support #224

Closed
lorenzoh opened this issue May 12, 2022 · 1 comment · Fixed by #240
Closed

Makie 0.17 support #224

lorenzoh opened this issue May 12, 2022 · 1 comment · Fixed by #240
Labels
bug Something isn't working

Comments

@lorenzoh
Copy link
Member

lorenzoh commented May 12, 2022

When using Makie.jl 0.17, there are some errors cropping (see https://github.com/FluxML/FastAI.jl/runs/6404954707?check_suite_focus=true) up in the code for showing multiple observations, here:

# Add titles to named blocks
M.Label(grid[0, 1], "", tellwidth = false, textsize = 25)
for (i, title) in enumerate(header)
M.Label(grid[1, i], title, tellwidth = false, textsize = 25)
end

This code tries to add titles to the beginning of each column of a previously created GridLayout.

@lorenzoh lorenzoh added the bug Something isn't working label May 12, 2022
@lorenzoh
Copy link
Member Author

Current plan is to create a separate package FastMakie.jl that holds the Makie-related code. This way, we won't need Requires.jl and FastAI.jl + domain libraries can depend on MakieCore.jl to define recipes for visualizing their Blocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant