Move pg operations(commands) from ssh to http #64
Conversation
pkg/commands/handler.go
Outdated
| http.HandleFunc("/commands/users/create", handleCreateUser) | ||
| http.HandleFunc("/commands/users/delete", handleDeleteUser) | ||
|
|
||
| http.HandleFunc("/commands/users/grant", handleGrantAccess) |
There was a problem hiding this comment.
You can ditch the grant/revoke handlers, these operations should be handled by user create/delete.
* Using go-chi for routing * Revert changes done to fly.toml * Serving from 5500 only
| r.HandleFunc("/flycheck/vm", runVMChecks) | ||
| r.HandleFunc("/flycheck/pg", runPGChecks) | ||
| r.HandleFunc("/flycheck/role", runRoleCheck) | ||
|
|
There was a problem hiding this comment.
What are your thoughts on combining the command/check handlers into a single file and keeping them under the same port?
There was a problem hiding this comment.
@davissp14 I've put them on the same port but they are still in different packages that are imported by a new package pkg/server. I could rename it though.
rugwirobaker
changed the title
rugwirobaker
changed the title
|
|
||
| name := chi.URLParam(r, "name") | ||
|
|
||
| db, err := admin.FindDatabase(r.Context(), pg, name) |
There was a problem hiding this comment.
This seems to return status code 500 when the the target database doesn't exist.
Flyctl expects 404: https://github.com/superfly/flyctl/blob/be327db0075b8e4bb35eda4c8359da0936b0c42d/pkg/flypg/pg.go#L92
|
I've tested out list users and list databases and both look good! I haven't been able to fully test attach/detach due to an issue noted in the last review.
|
superfly/flyctl#893