Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial import of WorkingTitle flight plan manager #2831

Closed
wants to merge 36 commits into from

Conversation

Benjozork
Copy link
Member

@Benjozork Benjozork commented Jan 1, 2021

Fixes #939
Fixes #1388

Summary of Changes

Flight plan manager

  • Initial code import
  • Remove dependency on "MSFS" pseudo-module, use ambient type declarations for MSFS globals instead

Avionics

  • Fix navigation display
    • Instrument loading
    • Share flightplan correctly (often goes out of sync)
    • No line drawn for approach waypoints
    • Do not draw line after discontinuities
  • Fix upper ECAM

MCDU/FMGC

  • Fix F-PLN page
    • Approach waypoints being shown twice
    • Discontinuities
      • Display
      • Clearing
    • Allow deleting fixes in STARs
    • Fix various LSK and scrolling issues
  • Fix arrival selection page
    • UNTITLED screen on load
    • UNTITLED screen when an approach transition is selected
    • UNTITLED screen when a via is selected
  • Get rid of / hide RWXXX fixes
  • Adapt fix naming to Honeywell FMGS
    • (VECT) -> MANUAL
    • (<altitude>) -> <altitude>
    • others
  • Properly add FA legs to departures without SIDs
  • Do not allow selection of "fake" SIDs (ref. @tareksabet)
  • Support compressed flight plans

Autopilot

  • Integrate LNAV code

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created and uploaded.
The build script will have already been run with the latest changes, so no need to rerun it once you download the zip.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the right side, click on the Artifacts drop down and click the A32NX link

@Benjozork Benjozork force-pushed the wt-fpm branch 2 times, most recently from 6fb8c50 to 1dda452 Compare January 1, 2021 20:09
@Benjozork Benjozork added this to the v0.6.0 milestone Jan 3, 2021
@Benjozork Benjozork force-pushed the wt-fpm branch 2 times, most recently from d057f25 to 198de48 Compare January 4, 2021 16:34
@St54Kevin
Copy link
Contributor

This seems HUGE. Thanks for addressing it!

@pepperoni505
Copy link
Contributor

This seems HUGE. Thanks for addressing it!

Please avoid unnecessary conversations in pull requests.

Benjozork and others added 26 commits February 11, 2021 00:09
As we're essentially just checking a SimVar and bailing otherwise we might
as well do this more regularly in order to make the ND more responsive.
@Benjozork
Copy link
Member Author

Closing as it's being done in the autopilot-fpm branch now

@Benjozork Benjozork closed this Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot delete or edit waypoints in a STAR [BUG] AP not following STAR or approach
5 participants