-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SD): add a display timer on status page #8048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lint is failing, please fix |
2hwk
requested changes
Jun 4, 2023
Quality Assurance
automation
moved this from 🟡 Code Review: Ready for Review
to 🔴 Code Review: In progress
Jun 4, 2023
2hwk
requested changes
Jun 4, 2023
should be good @2hwk thanks ! |
Benjozork
approved these changes
Jun 11, 2023
2hwk
approved these changes
Jun 11, 2023
Quality Assurance
automation
moved this from 🔴 Code Review: In progress
to 🟣 QA Team Review: Ready to Test
Jun 11, 2023
Quality Assurance Tester Report Discord: Mack674#2274 Testing Process:
Negatives: N/A Testing Results: Passed Conclusions: Works as intended. Great job! Media: Microsoft.Flight.Simulator.2023-06-30.17-33-47.mp4 |
Quality Assurance
automation
moved this from 🟣 QA Team Review: Ready to Test
to ✔️ Done
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8046
Summary of Changes
The Status Page page of lower ECAM / System Display should appear only 3s if no failures are to be shown. This PR adds this timer before coming back to previous page.
Also replaces hardcoded values by constants to improve readability in the PageContainer component.
References
FCOM (page 1190)
![STS_button](https://private-user-images.githubusercontent.com/2952153/241408650-93edd5d0-f4c2-4ab9-ac55-22bd0f4a28cf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxMzQ3MjgsIm5iZiI6MTcyMjEzNDQyOCwicGF0aCI6Ii8yOTUyMTUzLzI0MTQwODY1MC05M2VkZDVkMC1mNGMyLTRhYjktYWM1NS0yMmJkMGY0YTI4Y2YucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjhUMDI0MDI4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjZiN2JhNDk3ZDlmZTQ0ODIyM2JkZWFiNjc2YjYxN2U5ZDBhYTBkOGFiMjhmMzM3M2RlOTA2OGY1MzY5ZDExNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.zL5suWOxCHkfDtoa2js7Z818bXLQgl6ZGV82dgVuG-A)
Additional context
First PR 👀
Testing instructions
Should not change behaviour of lower ECAM beside returning to previous page after 3s if no failure. I couldn't make Status page to be filled by anything, but after a discussion on Discord it may be normal.
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.