Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SD): add a display timer on status page #8048

Merged
merged 7 commits into from
Jun 30, 2023

Conversation

pluce
Copy link
Contributor

@pluce pluce commented May 28, 2023

Fixes #8046

Summary of Changes

The Status Page page of lower ECAM / System Display should appear only 3s if no failures are to be shown. This PR adds this timer before coming back to previous page.
Also replaces hardcoded values by constants to improve readability in the PageContainer component.

References

FCOM (page 1190)
STS_button

Additional context

First PR 👀

Testing instructions

Should not change behaviour of lower ECAM beside returning to previous page after 3s if no failure. I couldn't make Status page to be filled by anything, but after a discussion on Discord it may be normal.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@pluce pluce changed the title Fix/ecam sts delay Fix(SD): add a display timer on status page May 28, 2023
@pluce pluce marked this pull request as ready for review May 28, 2023 10:50
@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance May 28, 2023
@pluce pluce changed the title Fix(SD): add a display timer on status page fix(SD): add a display timer on status page May 28, 2023
@pluce
Copy link
Contributor Author

pluce commented May 28, 2023

  • Change the constants list for pages to an Enum

@2hwk
Copy link
Member

2hwk commented Jun 4, 2023

Quality Assurance automation moved this from 🟡 Code Review: Ready for Review to 🔴 Code Review: In progress Jun 4, 2023
@2hwk 2hwk added this to the 0.10.1 milestone Jun 4, 2023
@pluce
Copy link
Contributor Author

pluce commented Jun 4, 2023

should be good @2hwk thanks !

@pluce pluce requested a review from 2hwk June 4, 2023 12:27
Quality Assurance automation moved this from 🔴 Code Review: In progress to 🟣 QA Team Review: Ready to Test Jun 11, 2023
@Mack674
Copy link

Mack674 commented Jun 30, 2023

Quality Assurance Tester Report

Discord: Mack674#2274
Object of testing: #8048
Tier of Testing: 1
Date: 30/06/2023

Testing Process:

  • Spawned C&D at the gate
  • Turned on Batteries 1&2 and external power
  • Checked behaviour of STS ecam page

Negatives: N/A

Testing Results: Passed

Conclusions: Works as intended. Great job!

Media:

Microsoft.Flight.Simulator.2023-06-30.17-33-47.mp4

@Benjozork Benjozork enabled auto-merge (squash) June 30, 2023 19:18
@Benjozork Benjozork merged commit dd7a7d5 into flybywiresim:master Jun 30, 2023
6 checks passed
Quality Assurance automation moved this from 🟣 QA Team Review: Ready to Test to ✔️ Done Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

STS page on ecam
4 participants