Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Specification of A380X Public Flight Deck API #8372

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

frankkopp
Copy link
Member

Summary of Changes

Specification and documentation for the future public Flight Deck API using mainly B-Events.

This is a working document to define and document the public API mainly for Flightsim Hardware and Cockpit Builder usage.

Discord username (if different from GitHub): cdr_maverick

Testing instructions

N/A

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@frankkopp frankkopp added the Documentation Improvements or additions to documentation label Jan 3, 2024
@frankkopp frankkopp force-pushed the a380x-public-api-spec branch 6 times, most recently from 13c8d9e to 7ce9bfa Compare January 20, 2024 00:54
@frankkopp frankkopp force-pushed the a380x-public-api-spec branch 2 times, most recently from 41c00b9 to 139d5ec Compare April 27, 2024 16:47
@tracernz
Copy link
Member

The table format will be much more difficult to maintain than the section format in our current simvar docs. It is much too wide to fit in a typical browser window.

@frankkopp
Copy link
Member Author

The table format will be much more difficult to maintain than the section format in our current simvar docs. It is much too wide to fit in a typical browser window.

I wouldn't even call the current simvar docs a "format". It has none - is is an unstructured continuous unordered text mess.

The table format allows for structured access and reformatting into any format if required. Also easily reused for docs where we can the apply any css we want.

Separate structure from formatting - this allows us to reuse the data much more easily. E.g. put it into a database for a dynamic search or so.

Also priority is not to make it easy to maintain (although it actually is very easy with a good IDE like Jetbrains that supports md tables) but reusibilty and easy to read for end users.

@tracernz
Copy link
Member

tracernz commented Jun 18, 2024

I'd make a couple of points on this:

  • Sections of a doc that existed before a format was decided on are hardly a good counter-example
  • A key feature of markdown is that it's made to be hand-written and read; wide tables defeat that. and
  • The reasonable line length limit is somewhere around 120 chars; editor windows are often not wider than that
  • The docs in the repo are for maintainers, not for end-users, and they need to be easy to work with for maintainers
  • Jetbrains is not the recommended IDE for this project, and I don't think a proprietary software ever should be recommended or optimised for

@frankkopp
Copy link
Member Author

I'd make a couple of points on this:

  • Sections of a doc that existed before a format was decided on are hardly a good counter-example

  • A key feature of markdown is that it's made to be hand-written and read; wide tables defeat that. and

  • The reasonable line length limit is somewhere around 120 chars; editor windows are often not wider than that

  • The docs in the repo are for maintainers, not for end-users, and they need to be easy to work with for maintainers

  • Jetbrains is not the recommended IDE for this project, and I don't think a proprietary software ever should be recommended or optimised for

And it is still a data table and not formated text/table. If it wouldn't bring even more problems (to edit the data) I would have done this in Excel/Google Sheets or even CSV. It is about the structure and not the formatting. Formatting comes last. Using MD was just a middle ground as it is available within GitHub and most editors (btw. I did not say we have to use JetBrains although they do have free products which people could use - I said a good editor could handle ms tables - probably there is a plugin for VSC as well)

And I strongly disagree that I did this for maintainers only but mainly for the end users (cockpit builders, etc.)! The title allone clearly states "Public Flight Deck API" and not "FBW Internal Systems API". I hope you can see that it makes little sense that you try to convince me what my own intention was when creating this ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants