Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fms): allow SID name to be displayed on the ND #8782

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BravoMike99
Copy link
Contributor

@BravoMike99 BravoMike99 commented Jul 27, 2024

Fixes #[issue_no]

Summary of Changes

Allows FMS to publish SID identifier to ND as found on A380 & A350 aircraft currently.

Screenshots (if necessary)

image

References

A380/A350 FCOM, YT videos & preview picture of feature on A320

Additional context

Discord username (if different from GitHub):
bruno_pt99

Testing instructions

A32NX: Perform a normal flight and verify approach identifier shows on the ND as before, in addition, no SID name should be displayed on the ND during preflight & takeoff/climb (like the attached picture).
A380:

  1. Insert a SID on the flightplan and verify the SID name appears on top of ND.
  2. Fly the SID and perform a direct to a point of the SID prior to the final one, SID name should remain visible.
  3. Verify SID name disappears after last waypoint of SID is sequenced, or, after performing a direct to the last SID waypoint.
  4. Insert a SID and cruise flight level in a way that it will be reached before the end of SID. Verify that the SID name disappears once cruise level is reached.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@BravoMike99 BravoMike99 force-pushed the feat-a380-eis-departure branch 2 times, most recently from f5bb2b6 to fe281e8 Compare July 28, 2024 14:18
@BravoMike99 BravoMike99 marked this pull request as ready for review July 28, 2024 14:25
@tracernz
Copy link
Member

I feel like this is best implemented in the A380 ND + FMS only rather than a feature flag.

@Benjozork
Copy link
Member

I feel like this is best implemented in the A380 ND + FMS only rather than a feature flag.

The goal is to not have specific "380 FMS" sources as much as possible, so this has to go through a feature flag, like every other configurable aspect of the flight plan management that was added because it's different between 320/380 or different 320 FMS software versions.

Agree for the ND though.

@BravoMike99 BravoMike99 force-pushed the feat-a380-eis-departure branch 2 times, most recently from 9beb019 to abdda07 Compare August 23, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants