Lateral autopilot fix

[wpine215]

Fixes #2089

Summary of Changes

Fixes lateral autopilot/flight director deviation that arose since the last MSFS patch. Should fix wrongly accumulated integral term in the heading PID controller.

May need multiple cycles of extensive testing and iteration for tuning.

Screenshots (if necessary)

N/A

References

Special thanks to Sebastian from Asobo for helping to diagnose the issue and come up with this temporary solution.

Additional context

Discord username (if different from GitHub): Iceman#5540

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created and uploaded.
The build script will have already been run with the latest changes, so no need to rerun it once you download the zip.

1. Make sure you are signed in to GitHub
2. Click on the Checks tab on the PR
3. On the right side, click on the Artifacts drop down and click the A32NX link

[Snapmatics]

SEBASTIAN THE KING

[wpine215]

Tested it, full flight from cold-and-dark using SID's and STAR's. Engaged autopilot shortly after takeoff and kept it on until 1,000 feet RA before landing. Autopilot works with managed heading, selected heading, and capturing/tracking localizer, all without issue. The plane banks to its full range of motion (currently configured to 20 degrees) when necessary, both left and right. Plane follows flight plan without issue.

[armankir]

Everyone says it works so I guess it works lol, will test and write a report soon.

[Snapmatics]

Works for me

[FernandoPusineriWebMasterDesigner]

Hello !how can I do to join this patch to the latest version of the mod ?, because I downloaded it from the code and when I start the sim it does not grab the mod, only the default version. Thank you !

[CaptainR3X]

Category: QA Tester
Name: GustavRex #4347
Date of testing: Current date 30/11/2020
Version of the sim: 1.11.6.0
PR Tested: #2140
Object of test: Lateral AP fix

Testing technique: Flight; EKCH-ESGG
Steps you've made to test the Pull Request:

1. Normal flight programming, P/S, takeoff
2. Vectors on takeoff, climb via SID afterwards
3. Cruise, arrival planning, descent
4. Descent via SID, vectors to ILS intercept
5. Landing

Flight notes (If required): Online, VatSim

Issues (If Any): None
Overall Rating: Good
Conclusions of the testing: AP followed plan, following issues were no longer present;

• Heavy banking, fixed
• Ap not following plan (managed hdg), fixed
• HDG mode not working, fixed
• ILS intercept - AP not aligning, fixed

Thanks for your hard work guys. You've outdone yourselves here <3

[BritishAvgeek]

Category: QA Tester
Name: BritishAvgeek#1436 (used to be Carter633 now changed to match discord)
Date of testing: Current date 30/11/2020
Version of the sim: 1.11.6.0
PR Tested: #2140
Object of test: Dynamic fix for lateral autopilot issues

Testing technique: short full flight comparable to a route flown the other day with the issues

Steps you've made to test the Pull Request:

1. Spawned Cold&Dark EGCC, input all relevant data into aircraft
2. Depart EGCC for EGLL flying the SANB1R SID - via HON - into the BNN4A arrival and cruise FL190
3. Monitored systems for issues/track deviation
4. Land and complete flight, shut down

Issues (If Any): None
Overall Rating: Good
Conclusions of the testing: Nice work!

[Benjozork]

Hello !how can I do to join this patch to the latest version of the mod ?, because I downloaded it from the code and when I start the sim it does not grab the mod, only the default version. Thank you !

It will be in the development version within a few minutes

[LoungeFlyZ]

@wpine215 can you describe what these config values change? just interested.

[ImenesFBW]

Made two flights with problematic routes that haven't worked for me after the update.

Works great for me, no issues, thanks!

[dadavid77]

Thx guys, AP is working again !

[FinalLightNL]

Thankyou so much Sebastian !

[TheoBearman]

Hate to rain on the parade but I think some fine-tuning is still required. Coupled with the 20-degree maximum bank it does take a while to get round corners as well as settle on a course, even in flat calm weather.

Perhaps an updated stable build which incorporates this fix would be useful while everything else in the dev version is smoothed out?

Thanks a lot for the efforts @wpine215 and @AsoboStudio.

[felixalmont09]

I was doing LFPG-LIRF just now and AP had the same left bank tendency on departure, HD wasnt working either. It was working in the dev version prior to the last one updated like 2h ago.

[Benjozork]

This is a temporary fix to make the plane usable.

[Benjozork]

I was doing LFPG-LIRF just now and AP had the same left bank tendency on departure, HD wasnt working either. It was working in the dev version prior to the last one updated like 2h ago.

This sounds like an issue with deadzones. Try setting them to 10%.

[felixalmont09]

dead zones are at 10 already. I thought the dev version updated earlier looks like it didnt. I downloaded again going to do another flight now and see.

…

On Mon, Nov 30, 2020 at 17:14 Benjamin Dupont ***@***.***> wrote: I was doing LFPG-LIRF just now and AP had the same left bank tendency on departure, HD wasnt working either. It was working in the dev version prior to the last one updated like 2h ago. This sounds like an issue with deadzones. Try setting them to 10%. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2140 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR44RHEPSPOLOKVOJE6DFOTSSQKNBANCNFSM4UH7CY6A> .

[DeadManDrift]

Thank you so much for what you do!

I have noticed after updating to the current Dev build, my v speeds are weird. V1 shows -5 VR shows -4 and V2 is blank. If I fill in number based off of the performance calculator, I get an error that says V1/VR/V2 Disagree... Has anyone else noticed that? Usually my v speeds are blank and I do not get the error.

Thanks for your time!

[Benjozork]

Thank you so much for what you do!

I have noticed after updating to the current Dev build, my v speeds are weird. V1 shows -5 VR shows -4 and V2 is blank. If I fill in number based off of the performance calculator, I get an error that says V1/VR/V2 Disagree... Has anyone else noticed that? Usually my v speeds are blank and I do not get the error.

Thanks for your time!

Hello, this has been fixed and is currently pending merge into the development version.

[DeadManDrift]

Thank you so much for what you do!
I have noticed after updating to the current Dev build, my v speeds are weird. V1 shows -5 VR shows -4 and V2 is blank. If I fill in number based off of the performance calculator, I get an error that says V1/VR/V2 Disagree... Has anyone else noticed that? Usually my v speeds are blank and I do not get the error.
Thanks for your time!

Hello, this has been fixed and is currently pending merge into the development version.

Thank you again!

[Awemeter]

Category: Trial QA tester
Name: Awemeter#7919
Date of testing: 11/30/2020
Version of the sim: 1.11.6.0
PR Tested:#2140
Object of test: Lateral autopilot fix

Testing technique: Went in sim and did a flight.
Steps you've made to test the Pull Request:

1. Started C&D and planed mcdu normally at katl.
2. Took off and engages autopilot. Autopilot follows its path and Flight director works properly.
3. Landed at kmco

Flight notes (If required):

Issues (If Any): At cruise had very aggressive rocking.
Overall Rating: Good
Conclusions of the testing: Everything looks really good no problems found that are new to this or. The autopilot problem is fixed.

[wchafe]

Repeated flight that previously had issues with wing rocking initiated by setting manual hdg mode. Hdg mode did not cause wing rocking. Only issue was about 1 hour into the flight wing rocking started while nearing a waypoint. Rocking was moderate and did not change in amplitude. Turned off SEC2 momentarily, wing rocking stopped. Re-engaged SEC2, rocking do not return for a long time, but eventually happened again. Toggling SEC2 fixed it again.
Otherwise AP/FD appeared to work normally with one exception, which is probably an unrelated issue. That is, when manual HDG mode was engaged during CLM the Pitch mode annunciator on the ADI went blank. It returned when heading was changed back to managed mode. Repeated multiple times.

[felixalmont09]

So i updated the dev version again and AP is working now.

[fabianoheringer]

Updated, working now!

[npavia5]

where is this link

[Benjozork]

Locked as conversation is going into irrelevant topics. Please seek installation assistance on our Discord and talk about the rocking issue in #2005.