-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tcas): TCAS TA/RA logic and annunciations (ReactJS/TS) #5934
Conversation
21ff550
to
7a5c6d9
Compare
7babfea
to
8efa0a3
Compare
7a5c6d9
to
8f58c6a
Compare
1d8bfa5
to
5cea41d
Compare
c888745
to
877aeda
Compare
d400073
to
0ba7bb4
Compare
e1cf585
to
3aa5b1b
Compare
tcas seems to give random calls sometimes even before traffic traffic sometimes I get "clear of conflict" or "monitor vertical speed" |
This comment has been minimized.
This comment has been minimized.
Nuisance RAs are entirely possible without a prior TA and happen often with AI Traffic (which again can spawn and position in such a way that RAs will be triggered). In some cases this is a bug, in others this is because we are still missing some finer aspects of RA filtering and in others because of AI Traffic bugs which we can't do much about on our side. This will be tuned but needs further testing, again the main purpose of this targeted towards VATSIM and injected traffic, rather than the currently bugged live traffic. |
This comment has been minimized.
This comment has been minimized.
02e8ca1
to
bb1181f
Compare
bb1181f
to
bb83b38
Compare
Co-authored-by: Will Pine <wpine215@gmail.com>
Co-authored-by: Will Pine <wpine215@gmail.com>
b0a99da
to
bea612d
Compare
Co-authored-by: Will Pine <wpine215@gmail.com>
Co-authored-by: Will Pine <wpine215@gmail.com>
…sim#5934 Co-authored-by: Will Pine <wpine215@gmail.com>
Co-authored-by: Will Pine <wpine215@gmail.com>
Co-authored-by: Will Pine <wpine215@gmail.com>
3942ece
to
69ee2ae
Compare
Co-authored-by: Will Pine <wpine215@gmail.com>
Co-authored-by: Will Pine <wpine215@gmail.com>
Co-authored-by: Will Pine <wpine215@gmail.com>
9c4fce2
to
25faff3
Compare
Will be done in a later PR when TCAS is anyway moved to C++/Rust
Co-authored-by: Will Pine <wpine215@gmail.com>
25faff3
to
73a3d01
Compare
Fixes #130
Summary of Changes
This PR builds upon #2242 and #5162
Additional note:
This PR also includes some improvements to FDR (more fields to be available) and also a new parameter to control minimum simulation rate and maximum simulation rate. The reason is simply that FDR interface version needs to be managed and due to TCAS a new interface version is anyway needed. So to reduce number of interface versions those changes will come with this PR.
Autopilot features: (beside TCAS)
Features:
windshear/stallcondition or during GPWS "glideslope" warning ("TA ONLY" message on ND)Inhibit all RA's for non-altitude reporting aircraft above 15,500 ft MSL (currently not possible given sim data)Implement HMD (horizontal miss distance) filtering(Probably not in this PR)Add TCAS testIssues:
Nuisance TA/RA due to teleporting AI traffic (default AI Traffic) - Asobo bug can't fix, workaround in placeGround traffic always has XPDR on/no XPDR information - Asobo bug can't fix, workaround in placeScreenshots (if necessary)
https://streamable.com/h3n0es (OLD)
https://cdn.discordapp.com/attachments/739225362642501672/892960697871372348/5HjsMJaduh.webm
References
Additional context
Discord username (if different from GitHub):
Testing instructions
Live traffic issue:
https://cdn.discordapp.com/attachments/817470205260726322/894460313443905536/hT8mG2OPgM.webm
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.