Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payload): flyPad OS 3.2 - multiple gate boarding when multiple boarding points are opened #8206

Merged
merged 37 commits into from Sep 17, 2023

Conversation

2hwk
Copy link
Member

@2hwk 2hwk commented Sep 10, 2023

Fixes #[issue_no]

Summary of Changes

  • Adds multiple gate boarding support
  • Services Page
  • Proper GSX Support (?)
  • Estimated boarding time displays correctly
  • GSX Config to enable dual gate for GSX

Not addressed in this PR:

  • EFB Payload Front End
  • Door Animations
  • Ground Vehicles (ask asobo)

Screenshots (if necessary)

image

FlightSimulator_sUaEUSNy8K

Bye

Note: Outdated, Aft Right door does not work for boarding, only catering.

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  1. Complete Boarding without any doors/jetway attached, this should work as per the usual boarding process before, then deboard the plane entirely and wait for all sounds to clear (boarding etc.)
  2. Go to the services page and open 2 doors (Fwd Left and Aft Left) to enable dual-gate boarding.
  3. Go back to the payload page and load passengers (with simbrief or manual entry)
  4. The estimated boarding time displayed should be half the duration as previously (less than 10 min)
  5. Start a real or fast time boarding and observe that the estimated duration is accurate, and that the passengers are shown as being filled from both the front and back of the aircraft.
  6. Check that deboarding also works in exactly the same way but with the passengers being deboarded from both the front and back of the aircraft.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@2hwk 2hwk added this to the v0.11.0 milestone Sep 10, 2023
@2hwk 2hwk added the Waiting for PR merge Waiting for PR to be merged to fix the issue. label Sep 10, 2023
@2hwk 2hwk changed the title feat(payload): Multiple gate boarding when multiple boarding points are opened feat(payload): flypad OS 3.2 - multiple gate boarding when multiple boarding points are opened Sep 11, 2023
@2hwk 2hwk changed the title feat(payload): flypad OS 3.2 - multiple gate boarding when multiple boarding points are opened feat(payload): flyPad OS 3.2 - multiple gate boarding when multiple boarding points are opened Sep 11, 2023
@2hwk 2hwk removed the Waiting for PR merge Waiting for PR to be merged to fix the issue. label Sep 11, 2023
@2hwk 2hwk marked this pull request as ready for review September 11, 2023 00:50
@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance Sep 11, 2023
Copy link
Member

@tracernz tracernz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS side looks fine. Didn't review rust. I think we have about 4 different PRs or branches with different A380 package manifests and build scripts now so we might want to just standardise on the comprehensive work @Benjozork and @flogross89 are doing.

Quality Assurance automation moved this from 🟡 Code Review: Ready for Review to 🟣 QA Team Review: Ready to Test Sep 13, 2023
Copy link
Contributor

@Gurgel100 Gurgel100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review from the Rust part.

fbw-common/src/wasm/systems/systems/src/payload/mod.rs Outdated Show resolved Hide resolved
fbw-common/src/wasm/systems/systems/src/payload/mod.rs Outdated Show resolved Hide resolved
Quality Assurance automation moved this from 🟣 QA Team Review: Ready to Test to 🔴 Code Review: In progress Sep 14, 2023
@2hwk 2hwk requested a review from Gurgel100 September 15, 2023 15:16
Quality Assurance automation moved this from 🔴 Code Review: In progress to 🟣 QA Team Review: Ready to Test Sep 16, 2023
@alepouna
Copy link
Contributor

QA Report - A32NX

Discord: alepouna
Object of testing: #8206
Tier of Testing : 1
Date : 17/09/2023

Testing Process:

  • [PASS] Complete Boarding without any doors/jetway attached, this should work as per the usual boarding process before, then deboard the plane entirely and wait for all sounds to clear (boarding etc.)
  • Go to the services page and open 2 doors (Fwd Left and Aft Left) to enable dual-gate boarding.
  • Go back to the payload page and load passengers (with simbrief or manual entry)
  • [PASS] The estimated boarding time displayed should be half the duration as previously (less than 10 min)
  • [PASS] Start a real or fast time boarding and observe that the estimated duration is accurate, and that the passengers are shown as being filled from both the front and back of the aircraft.
  • [PASS] Check that deboarding also works in exactly the same way but with the passengers being deboarded from both the front and back of the aircraft.

Testing Results:
Passed

@2hwk 2hwk merged commit c7c6a84 into flybywiresim:master Sep 17, 2023
6 checks passed
Quality Assurance automation moved this from 🟣 QA Team Review: Ready to Test to ✔️ Done Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants