Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(a380x): adjusted and added scrape points #8729

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Steveveepee
Copy link

@Steveveepee Steveveepee commented Jul 2, 2024

Summary of Changes

Added multiple scrape points on external extremities of the aircraft model as people will try and crash this into things.

Additional context

Currently there are only 4 wheels listed in the file. Should this be adjusted to include the fwd and rear wheel pair in each main gear to allow correct bogy animation on takeoff and landing?

All scrape points have Impact damage threshold crash velocity set to 100 ft/min at the moment, perhaps the points on the pods and tailscrape point could have higher values to allow sparking/dust/smoke but not 'crash' the a/c. Appropriate value to be determined.

Discord username : Shrike

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance Jul 2, 2024
@Steveveepee Steveveepee changed the title adjusted and added scrape points chore: adjusted and added scrape points Jul 2, 2024
@Steveveepee Steveveepee changed the title chore: adjusted and added scrape points chore(a380x): adjusted and added scrape points Jul 2, 2024
@flogross89
Copy link
Contributor

When trying it out, the sim seems to crash when selecting an airport to load. I discovered that you didn't update the max_number_of_points parameter, maybe that causes the crash?
https://docs.flightsimulator.com/html/Content_Configuration/SimObjects/Aircraft_SimO/flight_model/contact_points.htm#max_number_of_points

@2hwk 2hwk added Waiting For Response This issue or PR needs a response from the author Changes Requested labels Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Requested Waiting For Response This issue or PR needs a response from the author
Projects
Quality Assurance
🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants