Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pfd): (a380x, third try): Add vertical deviation indicator, ROW/ROP/OANS warnings v3 #8734

Merged

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Jul 3, 2024

Summary of Changes

Relevant for A380X only.

  • Adds OANS, ROP and ROW warnings to the PFD and aural alerts

  • Transmits new EGPWS discrete words from the GPWS module

  • Implements stall warning (aural alert and PFD warning)

  • Adds GPWS alerts to PFD

  • Ports the VDEV indicator, as well as the upper and lower speed limits from the a32nx to the a380x

  • Adds LS reminder for ILS, subsequently move marker (OM/MM/IM) information

  • ILS information: Frequency now has the same font size before and after decimal point, see references

Screenshots (if necessary)

image
image
image
image
image
image
image
image
image
image

image
image
image
image
image
image
image
image

References

https://www.youtube.com/watch?v=EorNGwNTzwQ
https://www.navblue.aero/product/rops-plus/
https://safetyfirst.airbus.com/app/themes/mh_newsdesk/documents/archives/the-runway-overrun-prevention-system.pdf
https://www.youtube.com/watch?v=FbCIjWaMqTI
https://www.youtube.com/watch?v=hDh_9MEz-hg
image

Additional context

Discord username (if different from GitHub): floridude

Testing instructions

Normal Tier 2 flight, make sure that nothing changed in the A32NX, especially with flight guidance and PFD display.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

flogross89 and others added 30 commits April 29, 2024 00:36
A32NX: Add GPWS discrete word to GPWS,
Both: warnings position update
# Conflicts:
#	fbw-a380x/src/systems/instruments/src/PFD/FMA.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/LandingSystemIndicator.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/PFD.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/SpeedIndicator.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/instrument.tsx
@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance Jul 3, 2024
Quality Assurance automation moved this from 🟡 Code Review: Ready for Review to 🟣 QA Team Review: Ready to Test Jul 3, 2024
@Saschl
Copy link
Member

Saschl commented Jul 8, 2024

Quality Assurance Report

Discord: Saschl
Object of testing: #8734
Tier of Testing: 2

Testing Process:

Full flight LOWW - ENGM

Performed the flight and especially observed flight plan updates and ND. Flightplan updated immediately and smoothly as before.

Negatives:
N/A

Testing Results:
Passed

Conclusions:
No regressions found.

@flogross89 flogross89 merged commit cc89848 into flybywiresim:master Jul 8, 2024
7 checks passed
Quality Assurance automation moved this from 🟣 QA Team Review: Ready to Test to ✔️ Done Jul 8, 2024
@flogross89 flogross89 deleted the fix-a380x-pfd-vdev-a380xonly branch July 27, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants