-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pfd): (a380x, third try): Add vertical deviation indicator, ROW/ROP/OANS warnings v3 #8734
Merged
flogross89
merged 53 commits into
flybywiresim:master
from
flogross89:fix-a380x-pfd-vdev-a380xonly
Jul 8, 2024
Merged
feat(pfd): (a380x, third try): Add vertical deviation indicator, ROW/ROP/OANS warnings v3 #8734
flogross89
merged 53 commits into
flybywiresim:master
from
flogross89:fix-a380x-pfd-vdev-a380xonly
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A32NX: Add GPWS discrete word to GPWS, Both: warnings position update
…ize before and after decimal point
…t gauge and PFD tapes
# Conflicts: # fbw-a380x/src/systems/instruments/src/PFD/FMA.tsx # fbw-a380x/src/systems/instruments/src/PFD/LandingSystemIndicator.tsx # fbw-a380x/src/systems/instruments/src/PFD/PFD.tsx # fbw-a380x/src/systems/instruments/src/PFD/SpeedIndicator.tsx # fbw-a380x/src/systems/instruments/src/PFD/instrument.tsx
# Conflicts: # .github/CHANGELOG.md # fbw-a380x/src/systems/systems-host/systems/LegacyGpws.ts # fbw-common/src/systems/shared/src/Arinc429RegisterSubject.ts
# Conflicts: # .github/CHANGELOG.md
Saschl
approved these changes
Jul 3, 2024
Quality Assurance
automation
moved this from 🟡 Code Review: Ready for Review
to 🟣 QA Team Review: Ready to Test
Jul 3, 2024
Lucky38i
approved these changes
Jul 3, 2024
Quality Assurance Report Discord: Saschl Testing Process: Full flight LOWW - ENGM Performed the flight and especially observed flight plan updates and ND. Flightplan updated immediately and smoothly as before. Negatives: Testing Results: Conclusions: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Relevant for A380X only.
Adds OANS, ROP and ROW warnings to the PFD and aural alerts
Transmits new EGPWS discrete words from the GPWS module
Implements stall warning (aural alert and PFD warning)
Adds GPWS alerts to PFD
Ports the VDEV indicator, as well as the upper and lower speed limits from the a32nx to the a380x
Adds LS reminder for ILS, subsequently move marker (OM/MM/IM) information
ILS information: Frequency now has the same font size before and after decimal point, see references
Screenshots (if necessary)
References
https://www.youtube.com/watch?v=EorNGwNTzwQ
![image](https://private-user-images.githubusercontent.com/63071941/328721103-27420678-8156-4228-a872-dbe1b863d6cc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI1NTcwNzAsIm5iZiI6MTcyMjU1Njc3MCwicGF0aCI6Ii82MzA3MTk0MS8zMjg3MjExMDMtMjc0MjA2NzgtODE1Ni00MjI4LWE4NzItZGJlMWI4NjNkNmNjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODAxVDIzNTkzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIxYTBmNzUxYjllYzY5OGM4MDk0YzZiMzJiYTAxNjQ4YzlhMWRjMzRkMDg2MTU0NTAzOWQzZjQ2OWZmNjkzY2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Njw1DbRVNkheueU2Ew_FGC02K4s1BfNtE5n67yXqUF4)
https://www.navblue.aero/product/rops-plus/
https://safetyfirst.airbus.com/app/themes/mh_newsdesk/documents/archives/the-runway-overrun-prevention-system.pdf
https://www.youtube.com/watch?v=FbCIjWaMqTI
https://www.youtube.com/watch?v=hDh_9MEz-hg
Additional context
Discord username (if different from GitHub): floridude
Testing instructions
Normal Tier 2 flight, make sure that nothing changed in the A32NX, especially with flight guidance and PFD display.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.