Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fms): implement intercepts of track-to-fix legs #8745

Merged
merged 4 commits into from
Jul 14, 2024

Conversation

BlueberryKing
Copy link
Member

@BlueberryKing BlueberryKing commented Jul 7, 2024

Fixes #8742

Summary of Changes

Previously leg sequences of CI -> IF -> TF was not dealt with properly in the geometry computation. This is fixed now.

Screenshots (if necessary)

FMMI RWY11 MJ4E before
image

FMMI RWY 11 MJ4E after
image
LPLA RWY 33 REGLA1B after
image
LPFR RWY 10 BAROK7E after
image

EGPH ILS 24 via TLA
image

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Fly the listed procedures (with MSFS navdata), make sure that the SIDs are displayed properly with and without speed predictions. Make sure the procedures are flown properly.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@BlueberryKing BlueberryKing marked this pull request as ready for review July 10, 2024 17:24
@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance Jul 10, 2024
Quality Assurance automation moved this from 🟡 Code Review: Ready for Review to 🟣 QA Team Review: Ready to Test Jul 14, 2024
@2hwk 2hwk added this to the v0.12.0 milestone Jul 14, 2024
@2hwk
Copy link
Member

2hwk commented Jul 14, 2024

image

Quality Assurance Report

Discord: 2cas
Object of testing: #8745
Tier of Testing: 1
Date: 14/7/2024

Testing Process:

  1. Fly the listed procedures (with MSFS navdata), make sure that the SIDs are displayed properly with and without speed predictions. Make sure the procedures are flown properly.

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM

@2hwk 2hwk moved this from 🟣 QA Team Review: Ready to Test to ⌛ Awaiting Actions in Quality Assurance Jul 14, 2024
@2hwk 2hwk merged commit 5a5eb07 into flybywiresim:master Jul 14, 2024
7 checks passed
Quality Assurance automation moved this from ⌛ Awaiting Actions to ✔️ Done Jul 14, 2024
@BlueberryKing BlueberryKing deleted the feat-xiiftf branch July 18, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

FMS: LPLA RWY 33 REGLA1B SID guidance/vnav crash
2 participants