New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proselint checker #1304
Add proselint checker #1304
Conversation
b518e28
to
d27ead2
Compare
Unset LC_ALL which is set to LC_ALL=C for other checkers in test/run.el, because Click, used by ProseLint, when running with python 3 will refuse to work unless an Unicode locale is exported[1]. [1] http://click.pocoo.org/5/python3/#python-3-surrogate-handling
d27ead2
to
f13a2fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I've looked through this, and it looks like a no-brainer, but would a more active maintainer care to click "merge" if they agree please? |
Any reason to use |
@cpitclaudel I never quite managed to understand the docstring of |
They expand to the same thing :) (as an example, here's what our use of pcase in the checkstyle parser expands to:)
|
@cpitclaudel Good to know (but still confusing to have two ways to state the same thing) :) |
Hi:
This is a rebase of #939
Minor changes with respect to #939:
gfm-mode
to:modes
json-read-from-string
withflycheck-parse-json
Related: