Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proselint checker #1304

Merged
merged 2 commits into from Sep 2, 2017
Merged

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Aug 20, 2017

Hi:

This is a rebase of #939

Minor changes with respect to #939:

  • Use standard input
  • Added gfm-mode to :modes
  • Replaced json-read-from-string with flycheck-parse-json

Related:

Unset LC_ALL which is set to LC_ALL=C for other checkers in test/run.el, because
Click, used by ProseLint, when running with python 3 will refuse to work unless
an Unicode locale is exported[1].

[1] http://click.pocoo.org/5/python3/#python-3-surrogate-handling
Copy link
Member

@purcell purcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@purcell
Copy link
Member

purcell commented Sep 2, 2017

I've looked through this, and it looks like a no-brainer, but would a more active maintainer care to click "merge" if they agree please?

@cpitclaudel cpitclaudel merged commit 9cd155b into flycheck:master Sep 2, 2017
@cpitclaudel
Copy link
Member

@purcell Thanks for the review. @marsam Thanks for your patience and your excellent work!

@cpitclaudel
Copy link
Member

Any reason to use (pcase (`"error" …) …) rather than (pcase ("error" …) …) btw? We use the former in multiple places (and it's valid according to the docs), but I hadn't paid attention to it before and I always use the latter.

@fmdkdd
Copy link
Member

fmdkdd commented Sep 2, 2017

@cpitclaudel I never quite managed to understand the docstring of pcase on that point to figure out if they were really equivalent, so I always go with the backtick, for coherency with the existing code.

@cpitclaudel
Copy link
Member

They expand to the same thing :) (as an example, here's what our use of pcase in the checkstyle parser expands to:)

(cond ((equal .severity '"error")
       'error)
      ((equal .severity '"warning")
       'warning)
      ((equal .severity '"info")
       'info)
      (t 'error))

@fmdkdd
Copy link
Member

fmdkdd commented Sep 3, 2017

@cpitclaudel Good to know (but still confusing to have two ways to state the same thing) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants