Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLint does not use flycheck-ghc-args #713

Closed
ntc2 opened this issue Aug 3, 2015 · 1 comment
Closed

HLint does not use flycheck-ghc-args #713

ntc2 opened this issue Aug 3, 2015 · 1 comment
Assignees
@swsnr

Comments

@ntc2
Copy link

ntc2 commented Aug 3, 2015

HLint does not use the flycheck-ghc-args setting. So, for example, custom settings of flycheck-ghc-args needed to define Cabal's backwards compatibility macros (MIN_VERSION_*) don't help the HLint flychecker, which still complains that they these macros are undefined. See flycheck/flycheck-haskell#39 (comment) for more details.
@swsnr swsnr added ready and removed ready labels Aug 5, 2015
@swsnr
Copy link
Contributor

swsnr commented Aug 5, 2015

We cannot blindly pass GHC arguments to Hlint. We'd need a separate option for hlint, but that needs a PR from you or someone else, because I have currently no need for that myself.

@swsnr swsnr added the feature label Sep 22, 2015
This was referenced Oct 16, 2015
Closed
Closed
@swsnr swsnr added the blocked label Oct 17, 2015
@swsnr swsnr self-assigned this Oct 17, 2015
swsnr pushed a commit that referenced this issue Oct 19, 2015
@mrkkrp @swsnr
Add option flycheck-hlint-args
a38c980 
Closes [GH-713], closes [GH-762].
@swsnr swsnr closed this as completed in bffb7ec Oct 19, 2015
@swsnr swsnr removed the blocked label Oct 19, 2015
jdnavarro added a commit to jdnavarro/flycheck-haskell that referenced this issue Jan 18, 2016
@jdnavarro
Support cabal macros for hlint checker
cbfc85c 
Sets the location of the `cabal_macros.h` as hlint arguments in the
`flycheck-hlint-args` variable. It supports the default Cabal and/or
Stack dist directories.

See flycheck/flycheck#713.
@jdnavarro jdnavarro mentioned this issue Jan 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swsnr swsnr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ntc2 @swsnr