Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert syntax checkers to use standard input #767

Closed
80 tasks done
swsnr opened this issue Oct 25, 2015 · 11 comments
Closed
80 tasks done

Convert syntax checkers to use standard input #767

swsnr opened this issue Oct 25, 2015 · 11 comments
Assignees

Comments

@swsnr
Copy link
Contributor

swsnr commented Oct 25, 2015

  • ada-gnat (can't read from standard input)
  • asciidoc
  • c/c++-clang
  • c/c++-gcc
  • c/c++-cppcheck (can't read from stdin)
  • cfengine (can't read from stdin)
  • chef-foodcritic (can't read from stdin)
  • coffee
  • coffee-coffeelint
  • coq (can't read from stdin)
  • css-csslint (no stdin)
  • d-dmd (no stdin)
  • emacs-lisp (no stdin)
  • emacs-lisp-checkdoc (no stdin)
  • erlang (no stdin)
  • eruby-erubis (behaves differently when using standard input)
  • fortran-gfortran (can't read from stdin without language option, don't know the proper value)
  • go-gofmt
  • go-golint (no stdin, wants a package)
  • go-vet (no stdin)
  • go-build (no stdin)
  • go-test (no stdin)
  • go-errcheck (no stdin, wants a package)
  • groovy (no stdin)
  • haml
  • handlebars
  • haskell-stack-ghc (GHC can't read from standard input)
  • haskell-ghc (GHC can't read from standard input)
  • haskell-hlint (needs file extension to determine source format)
  • html-tidy
  • jade
  • javascript-jshint
  • javascript-eslint
  • javascript-gjslint (doesn't read from stdin)
  • javascript-jscs
  • javascript-standard
  • json-jsonlint (doesn't print errors when using standard input?!)
  • less (no stdin support)
  • luacheck
  • lua
  • perl
  • perl-perlcritic
  • php
  • php-phpmd (can't read from stdin)
  • php-phpcs
  • puppet-parser
  • puppet-lint (can't read from stdin)
  • python-flake8
  • python-pylint (doesn't read from stdin)
  • python-pycompile (reads a list of files rather than source code from standard input)
  • r-lintr (can't read from stdin)
  • racket
  • rpm-rpmlint (fails to read from stdin with a very obscure file not found error)
  • rst
  • rst-sphinx (can't read from stdin, works only on whole projects)
  • ruby-rubocop
  • ruby-rubylint
  • ruby
  • ruby-jruby
  • rust (no standard input)
  • sass
  • scala (can't read from standard input)
  • scala-scalastyle (can't read from standard input)
  • scss-lint
  • scss
  • sh-bash
  • sh-posix-dash
  • sh-posix-bash
  • sh-zsh (zsh doesn't include column numbers when reading from standard input 😞)
  • sh-shellcheck
  • slim
  • sql-sqlint
  • tex-chktex
  • tex-lacheck (does not support standard input)
  • texinfo
  • verilog-verilator (can't read from stdin)
  • xml-xmlstarlet
  • xml-xmllint
  • yaml-jsyaml
  • yaml-ruby
purcell added a commit to purcell/flycheck that referenced this issue Oct 26, 2015
purcell added a commit to purcell/flycheck that referenced this issue Oct 26, 2015
purcell added a commit to purcell/flycheck that referenced this issue Oct 26, 2015
purcell added a commit to purcell/flycheck that referenced this issue Oct 26, 2015
purcell added a commit to purcell/flycheck that referenced this issue Oct 26, 2015
purcell added a commit to purcell/flycheck that referenced this issue Oct 26, 2015
purcell added a commit to purcell/flycheck that referenced this issue Oct 26, 2015
purcell added a commit to purcell/flycheck that referenced this issue Oct 26, 2015
purcell added a commit to purcell/flycheck that referenced this issue Oct 26, 2015
purcell added a commit to purcell/flycheck that referenced this issue Oct 26, 2015
@purcell
Copy link
Member

purcell commented Oct 26, 2015

One thing I noticed along the way is that it's often worth trying - as the filename: it's a long-standing UNIX convention taken to mean "stdin".

swsnr added a commit that referenced this issue Oct 26, 2015
swsnr added a commit that referenced this issue Oct 26, 2015
@kyptin
Copy link

kyptin commented Oct 30, 2015

I get errors popping up every few seconds in emacs' minibuffer because the version of rubocop that my project uses is v0.31.0, and rubocop didn't add support for the --stdin option until v0.34.0. Might be worth checking that the --stdin option is supported before trying to use it. Thanks!

@kyptin
Copy link

kyptin commented Oct 30, 2015

Also, I see now that the docstring for the ruby-rubocop checker includes a note about requiring v0.34.0. But the error message I got (shown below) didn't include this information. Might be worth augmenting the message. Anyway, thanks for your efforts on this! Meantime, I'll work on upgrading this project to rubocop v0.34.0. Cheers!

Suspicious state from syntax checker ruby-rubocop: Checker ruby-rubocop returned non-zero exit code 1, but no errors from output: invalid option: --stdin

@swsnr
Copy link
Contributor Author

swsnr commented Oct 30, 2015

@kyptin Thanks, but I don't think it's worth the effort. It's a corner case, arguably, and probing tools for supported options is going to end up in a kitchen sink of maintenance code :)

@kyptin
Copy link

kyptin commented Oct 30, 2015

Fair enough. At least now Google can find this thread, and people will know that updating rubocop should solve the issue. Thanks!

@swsnr
Copy link
Contributor Author

swsnr commented Oct 30, 2015

@kyptin Well, see #771 ☺️

@kyptin
Copy link

kyptin commented Oct 30, 2015

Ha, fair enough! I guess Google hasn't found that yet. :-)

purcell added a commit that referenced this issue Nov 1, 2015
purcell added a commit that referenced this issue Nov 1, 2015
purcell added a commit that referenced this issue Nov 1, 2015
purcell added a commit that referenced this issue Nov 1, 2015
purcell added a commit that referenced this issue Nov 1, 2015
purcell added a commit that referenced this issue Nov 1, 2015
purcell added a commit that referenced this issue Nov 1, 2015
purcell added a commit that referenced this issue Nov 1, 2015
swsnr added a commit that referenced this issue Nov 1, 2015
swsnr added a commit that referenced this issue Nov 1, 2015
swsnr added a commit that referenced this issue Nov 1, 2015
swsnr added a commit that referenced this issue Nov 1, 2015
swsnr added a commit that referenced this issue Nov 1, 2015
swsnr pushed a commit that referenced this issue Nov 4, 2015
swsnr added a commit that referenced this issue Nov 11, 2015
swsnr added a commit that referenced this issue Nov 11, 2015
swsnr added a commit that referenced this issue Nov 11, 2015
swsnr added a commit that referenced this issue Nov 11, 2015
swsnr added a commit that referenced this issue Nov 11, 2015
swsnr added a commit that referenced this issue Nov 11, 2015
@swsnr swsnr self-assigned this Nov 11, 2015
swsnr added a commit that referenced this issue Nov 11, 2015
swsnr added a commit that referenced this issue Nov 11, 2015
swsnr added a commit that referenced this issue Nov 14, 2015
swsnr added a commit that referenced this issue Nov 14, 2015
See GH-767, also refactor the tests
swsnr added a commit that referenced this issue Nov 14, 2015
See GH-767.  lacheck does not support stdin

Also move the test resource
swsnr added a commit that referenced this issue Nov 14, 2015
swsnr added a commit that referenced this issue Nov 14, 2015
swsnr added a commit that referenced this issue Nov 14, 2015
See GH-767.

Also move YAML test resource
@swsnr
Copy link
Contributor Author

swsnr commented Nov 14, 2015

All syntax checkers were converted as far as possible.

@swsnr swsnr closed this as completed Nov 14, 2015
@swsnr swsnr removed the in progress label Nov 14, 2015
@purcell
Copy link
Member

purcell commented Nov 14, 2015

Nice work @lunaryorn !

@swsnr
Copy link
Contributor Author

swsnr commented Nov 14, 2015

@purcell Thank you 😊

@cpitclaudel
Copy link
Member

Seconded; this is an amazing step for Flycheck :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants