Avoid nil for the default argument of ‘completing-read’. #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpitclaudel
reviewed
May 5, 2018
| @@ -1384,7 +1384,8 @@ to the default levels." | |||
| (flycheck-error-list-current-errors))) | |||
| (levels-with-defaults (append '(info warning error) levels)) | |||
| (uniq-levels (seq-uniq levels-with-defaults)) | |||
| (level (flycheck-completing-read prompt uniq-levels nil))) | |||
| (level (flycheck-completing-read prompt uniq-levels | |||
| (car uniq-levels)))) | |||
There was a problem hiding this comment.
This look wrong: we do want to offer an empty entry (it corresponds to setting a nil level)
| @@ -1364,7 +1364,7 @@ a default on its own." | |||
| (flycheck-defined-checkers property)))) | |||
| (default (and default (symbol-name default))) | |||
| (input (flycheck-completing-read | |||
| prompt candidates default | |||
| prompt candidates (or default (car candidates)) | |||
There was a problem hiding this comment.
The code below explicitly deals with the case of no checker selected case, so do we really need this?
|
Closing as this patch has gone stale. If the original concerns can be addressed, I'll be happy to have a new look. |
|
I created a separate PR, #1706, with a different fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the quirk described at
https://github.com/DarwinAwardWinner/ido-completing-read-plus#why-does-ret-sometimes-not-select-the-first-completion-on-the-list--why-is-there-an-empty-entry-at-the-beginning-of-the-completion-list--what-happened-to-old-style-default-selection.
Fixes #1418