Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying end column and end line for errors #1674

Closed
wants to merge 1 commit into from

Conversation

yyoncho
Copy link

@yyoncho yyoncho commented Feb 2, 2020

  • backends like lsp-ui could provide that data.

Before:
before

After:
after

@claassistantio
Copy link

claassistantio commented Feb 2, 2020

CLA assistant check
All committers have signed the CLA.

- backends like lsp-ui could provide that data.
@cpitclaudel
Copy link
Member

Did you see #1400 ?

@yyoncho
Copy link
Author

yyoncho commented Feb 2, 2020

Did you see #1400 ?

Yes - but it is stalled for not being backward compatible(unless I am mistaken) so I went for implementation that does not break existing backends(forgot to mention in the PR that a version with one region property could work too but it will require backends to do the (line, column) -> point conversion which might not be efficient). I don't mind rejecting this PR in favour of #1400 - it will for me too.

@yyoncho
Copy link
Author

yyoncho commented Feb 10, 2020

ping?

@cpitclaudel
Copy link
Member

Sorry for the delay (and thanks for the ping). I think this might be the most reasonable approach. We can fix the region performance issue at a later point. Let me just go through #1400 to see what else was relevant in that code.

@cpitclaudel
Copy link
Member

Closing in favor of #1676. Thanks for the PR.

I went for implementation that does not break existing backends

Note that as written, this PR isn't in fact backwards compatible, because the call to (flycheck-error-end-column err) will fail if err is created by a package compiled with a previous version of flycheck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants