Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese input bug #517

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

okano4413
Copy link
Contributor

What does it do?

Fix bug related on convertible character input issue like Japanese.

Why is it needed?

I think , some users who using CJK input are in trouble by this behavior.

How to test it?

How to reproduce?

  1. Build example project of flutter_chat_ui with web browser.
  2. Enter Japanese characters by Roman alphabets. for example, こんにちは(ko nn ni ti ha)
  3. If you entered above characters, you can see "kおんにちは" (Japanese input is wrong in Flutter web. #476 )
  4. Press enter key once, then "kおんにちは" is sent as message, and "おんにちは" remains in text field.( Remain characters being converted when press enter key with Japanese input. #514)

My commit fix these issues.

Related issues/PRs

#514
#476

@demchenkoalex demchenkoalex merged commit 132f317 into flyerhq:main Nov 1, 2023
2 checks passed
@demchenkoalex
Copy link
Member

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants