Default bubbled message to the bubbleBuilder #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to the bubbleBuilder. It now creates the default message, and sends it to the bubbleBuilder(). This way people can just spit back message as they see fit or wrap the message with their own widgets.
Changed the definition for the bubbleBuilder. It now has a defaultBubbleMessage which is the original message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This adds the default message to the bubbleBuilder(). This way the developer can spit back out the nicely formatted message but wrap it with any other widgets they so decide to choose.
Why is it needed?
People want to add options and other functionallity to messages. So we need to render stuff around the message.
How to test it?
Use the bubbleBuilder() method and make it return the default message. If messages show up it's working fine. Or return Text('blah') to see all of the messages are now "blah"
Related issues/PRs
The issues this is addressing:
#552
#508