Allow setting the visibility of the SendButton #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It adds the ability to change the visibility of the
SendButtonby introducing a new enum property calledsendButtonVisibilityModeto theChatwidget.When
sendButtonVisibilityModeparameter passed into theChatwidget, theInputwidget will check if the parameter is set toSendButtonVisibilityMode.always. If it is, theSendButtonalways be visible regardless of theTextFieldstate.If it is set to
SendButtonVisibilityMode.editing, theSendButtonwill be visible only if theTextFieldis not empty.The
sendButtonVisibilityModeparameter defaults toSendButtonVisibilityMode.editingto maintain the existing behavior.Why is it needed?
It will increase the flexibility when displaying the
SendButton.How to test it?
I've added some widget tests to not break the existing behavior and make sure everything works properly.
Related issues/PRs
Related #62