Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ActiveSupport dependency and delegation require #109

Merged
merged 1 commit into from
Jun 20, 2013
Merged

Adds ActiveSupport dependency and delegation require #109

merged 1 commit into from
Jun 20, 2013

Conversation

philostler
Copy link
Contributor

I am working with Bullet against Sinatra and got a failure to start my app with the following stacktrace...

NoMethodError: undefined method `delegate' for #<Class:Bullet>
    __singleton__ at C:/Ruby/jruby-1.7.4/lib/ruby/gems/shared/gems/bullet-4.6.0/lib/bullet.rb:31
           Bullet at C:/Ruby/jruby-1.7.4/lib/ruby/gems/shared/gems/bullet-4.6.0/lib/bullet.rb:27
           (root) at C:/Ruby/jruby-1.7.4/lib/ruby/gems/shared/gems/bullet-4.6.0/lib/bullet.rb:7
          require at org/jruby/RubyKernel.java:1054
           (root) at C:/Ruby/jruby-1.7.4/lib/ruby/gems/shared/gems/bundler-1.3.5/lib/bundler/runtime.rb:1
             each at org/jruby/RubyArray.java:1617
          require at C:/Ruby/jruby-1.7.4/lib/ruby/gems/shared/gems/bundler-1.3.5/lib/bundler/runtime.rb:72
             each at org/jruby/RubyArray.java:1617
          require at C:/Ruby/jruby-1.7.4/lib/ruby/gems/shared/gems/bundler-1.3.5/lib/bundler/runtime.rb:70
          require at C:/Ruby/jruby-1.7.4/lib/ruby/gems/shared/gems/bundler-1.3.5/lib/bundler/runtime.rb:59
          require at C:/Ruby/jruby-1.7.4/lib/ruby/gems/shared/gems/bundler-1.3.5/lib/bundler.rb:132
          require at org/jruby/RubyKernel.java:1054
          require at C:/Ruby/jruby-1.7.4/lib/ruby/shared/rubygems/custom_require.rb:36
           (root) at C:/Projects/basscamp/basscamp.rb:4
    instance_eval at org/jruby/RubyBasicObject.java:1735
           (root) at config.ru:1
  new_from_string at config.ru:1
             eval at org/jruby/RubyKernel.java:1093
       initialize at C:/Ruby/jruby-1.7.4/lib/ruby/gems/shared/gems/rack-1.5.2/lib/rack/builder.rb:55
  new_from_string at config.ru:0
  new_from_string at C:/Ruby/jruby-1.7.4/lib/ruby/gems/shared/gems/rack-1.5.2/lib/rack/builder.rb:49
       parse_file at C:/Ruby/jruby-1.7.4/lib/ruby/gems/shared/gems/rack-1.5.2/lib/rack/builder.rb:40
              app at C:/Ruby/jruby-1.7.4/lib/ruby/gems/shared/gems/puma-2.0.1-java/lib/puma/configuration.rb:83
       run_single at C:/Ruby/jruby-1.7.4/lib/ruby/gems/shared/gems/puma-2.0.1-java/lib/puma/cli.rb:428
             load at org/jruby/RubyKernel.java:1073
           (root) at C:\Ruby\jruby-1.7.4\bin\puma:23

Tracking back to this line it's clear that bullet.rb is attempting to use the delegate method in ActiveSupport but does state that this is required in gemspec and as a require definition.

This is masked by other gems that already loading this ActiveSupport module, e.g. if you happen to have factory_girl in the same bundle group as bullet then you won't see a problem

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7f215ac on philostler:activesupport_dependency into b68b980 on flyerhzm:master.

flyerhzm added a commit that referenced this pull request Jun 20, 2013
Adds ActiveSupport dependency and delegation require
@flyerhzm flyerhzm merged commit 0ae36b9 into flyerhzm:master Jun 20, 2013
@philostler philostler deleted the activesupport_dependency branch June 20, 2013 00:08
@philostler philostler restored the activesupport_dependency branch June 20, 2013 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants