Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullet should not automatically require ActiveRecord / Mongoid #110

Merged
merged 2 commits into from
Jun 26, 2013
Merged

Bullet should not automatically require ActiveRecord / Mongoid #110

merged 2 commits into from
Jun 26, 2013

Conversation

johnnyshields
Copy link
Contributor

Currently Bullet forces these libraries to be required in your application, however, this is not a good practice since many apps many want to intentionally exclude one of these libraries (like mine). Instead, it is better to check if they are already defined (which would have been done earlier in the Rails initialization chain)

…ntly Bullet forces these libraries to be required in your application, however, this is not a good practice since many apps many want to intentionally exclude one of these libraries (like mine). Instead, it is better to check if they are already defined (which would have been done earlier in the Rails initialization chain)
@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling dd105d9 on johnnyshields:master into 0ae36b9 on flyerhzm:master.

@johnnyshields
Copy link
Contributor Author

FYI I've tested this new version in my app (with Mongoid) and it looks like it's working normally

@flyerhzm
Copy link
Owner

it breaks travis ci, I think you should rescue LoadError, like

begin
  require 'mongoid'
rescue LoadError
end

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 5211da6 on johnnyshields:master into 0ae36b9 on flyerhzm:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling b50a664 on johnnyshields:master into 0ae36b9 on flyerhzm:master.

@flyerhzm
Copy link
Owner

@johnnyshields I still see some errors on travis ci, could you run sh test.sh on your local machine?

@johnnyshields
Copy link
Contributor Author

Should be good now

flyerhzm added a commit that referenced this pull request Jun 26, 2013
Bullet should not automatically require ActiveRecord / Mongoid
@flyerhzm flyerhzm merged commit 16f522b into flyerhzm:master Jun 26, 2013
@flyerhzm
Copy link
Owner

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants