Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix undefined method `id' for nil:NilClass error in Object#primary_key_value #234

Closed
wants to merge 1 commit into from
Closed

fix undefined method `id' for nil:NilClass error in Object#primary_key_value #234

wants to merge 1 commit into from

Conversation

zetavg
Copy link

@zetavg zetavg commented May 9, 2015

This might crash the application while dealing with models having nil relations (self = nil).

@zetavg
Copy link
Author

zetavg commented May 9, 2015

Duplicated with #230 😝

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.48% when pulling ad2bb5a on Neson:undefined-method-fix into 32ce3eb on flyerhzm:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.48% when pulling ad2bb5a on Neson:undefined-method-fix into 32ce3eb on flyerhzm:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.48% when pulling ad2bb5a on Neson:undefined-method-fix into 32ce3eb on flyerhzm:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.48% when pulling ad2bb5a on Neson:undefined-method-fix into 32ce3eb on flyerhzm:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.48% when pulling ad2bb5a on Neson:undefined-method-fix into 32ce3eb on flyerhzm:master.

@flyerhzm
Copy link
Owner

flyerhzm commented May 9, 2015

this fix just hides the error and will breaks bullet reports, it should fix where nil object passed

@flyerhzm flyerhzm closed this May 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zetavg @coveralls @flyerhzm