Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete trailing comma for Ruby 1.8/Rails 2.3 compatibility. #21

Merged
merged 1 commit into from Jun 10, 2014

Conversation

andrewhao
Copy link
Contributor

bugsnag.rb causes an error when we try to load uniform_notifier in our Rails 2.3 project:

=> Booting Mongrel
=> Rails 2.3.18 application starting on http://0.0.0.0:3000
/home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/activesupport-2.3.18/lib/active_support/dependencies.rb:182:in `require': /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/uniform_notifier-1.6.1/lib/uniform_notifier/bugsnag.rb:19: syntax error, unexpected ')' (SyntaxError)
      ))
       ^
        from /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/activesupport-2.3.18/lib/active_support/dependencies.rb:182:in `require'
        from /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/activesupport-2.3.18/lib/active_support/dependencies.rb:547:in `new_constants_in'
        from /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/activesupport-2.3.18/lib/active_support/dependencies.rb:182:in `require'
        from /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/uniform_notifier-1.6.1/lib/uniform_notifier.rb:10
        from /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/activesupport-2.3.18/lib/active_support/dependencies.rb:182:in `require'
        from /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/activesupport-2.3.18/lib/active_support/dependencies.rb:182:in `require'
        from /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/activesupport-2.3.18/lib/active_support/dependencies.rb:547:in `new_constants_in'
        from /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/activesupport-2.3.18/lib/active_support/dependencies.rb:182:in `require'
        from /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/bullet-4.5.0/lib/bullet.rb:2
        from /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/bundler-1.3.5/lib/bundler/runtime.rb:72:in `require'
        from /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/bundler-1.3.5/lib/bundler/runtime.rb:72:in `require'
        from /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/bundler-1.3.5/lib/bundler/runtime.rb:70:in `each'
        from /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/bundler-1.3.5/lib/bundler/runtime.rb:70:in `require'
        from /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/bundler-1.3.5/lib/bundler/runtime.rb:59:in `each'
        from /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/bundler-1.3.5/lib/bundler/runtime.rb:59:in `require'
        from /home/ahao/.rbenv/versions/ree-1.8.7-2012.02/lib/ruby/gems/1.8/gems/bundler-1.3.5/lib/bundler.rb:132:in `require'
        from /data/apps/blurby/config/boot.rb:121:in `load_environment'

@andrewhao
Copy link
Contributor Author

Deleting the trailing comma results in a happily loading gem.

flyerhzm added a commit that referenced this pull request Jun 10, 2014
Delete trailing comma for Ruby 1.8/Rails 2.3 compatibility.
@flyerhzm flyerhzm merged commit c2b8275 into flyerhzm:master Jun 10, 2014
@flyerhzm
Copy link
Owner

@andrewhao thanks

@andrewhao
Copy link
Contributor Author

That was fast! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants