Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] percona: adapt to new release scheme; update nixpkgs #1004

Merged
merged 5 commits into from
May 28, 2024

Conversation

osnyx
Copy link
Member

@osnyx osnyx commented May 7, 2024

  • pull in latest nixpkgs-unstable to get the new percona package set architecture
  • pull in both LTS and Innovation releases of percona
  • generate more parts of the percona role
  • provide versioned package aliases for specific Percona Innovation releases
  • update docs
  • adjust nginx test to updated nignx version

PL-132430

@flyingcircusio/release-managers

Release process

Impact: none, no production release yet

Changelog:

  • announce new Percona release support strategy in our release
  • provide both percona80 (LTS) and percona83 (Innovation) roles
  • drop percona81 support

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
    • no defaults involved
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • pull in updated packages to receive bug and security fixes
    • must not introduce known regressions
    • new package releases need to be covered by tests as well
    • announce version maintenance schedule for Percona
  • Security requirements tested? (EVIDENCE)
    • updated docs, built and manually checked the result
    • automated nixos tests need to pass
    • adjusted version number for updated nginx
    • added tests for percona83

@osnyx
Copy link
Member Author

osnyx commented May 7, 2024

Currently tests fail due to fc-userscan build failure:

scripts/tags.sh: interpreter directive changed from "#!/bin/bash" to "/nix/store/h3bhzvz9ipglcybbcvkxvm4vg9lwvqg4-bash-5.2p26/bin/bash"
warning: `fc-userscan` (bin "fc-userscan") generated 2 warnings
    Finished release [optimized] target(s) in 15.83s
scripts/tracing/ftrace-bisect.sh: interpreter directive changed from "#!/bin/bash" to "/nix/store/h3bhzvz9ipglcybbcvkxvm4vg9lwvqg4-bash-5.2p26/bin/bash"
scripts/tools-support-relr.sh: interpreter directive changed from "#!/bin/sh -eu" to "/nix/store/h3bhzvz9ipglcybbcvkxvm4vg9lwvqg4-bash-5.2p26/bin/sh -eu"
/nix/store/558iw5j1bk7z6wrg8cp96q2rx03jqj1v-stdenv-linux/setup: line 115: rst2man.py: command not found
/nix/store/558iw5j1bk7z6wrg8cp96q2rx03jqj1v-stdenv-linux/setup: line 131: pop_var_context: head of shell_variables not a function context
scripts/ver_linux: interpreter directive changed from "#!/usr/bin/awk -f" to "/nix/store/a2ffqcqzbp8k4fmkyhpjq2km0i9wr8d8-gawk-5.2.2/bin/awk -f"
error: builder for '/nix/store/ax6f6072a3k9mcwmms1x48pn6jahin42-fc-userscan-0.4.8.drv' failed with exit code 127;
       last 25 log lines:
       >    Compiling fc-userscan v0.4.8 (/build/fc-userscan-src-0.4.8)
       > warning: use of deprecated method `std::sync::atomic::AtomicBool::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead
       >   --> src/storepaths/cache.rs:65:28
       >    |
       > 65 |             if !self.dirty.compare_and_swap(true, false, Ordering::SeqCst) {
       >    |                            ^^^^^^^^^^^^^^^^
       >    |
       >    = note: `#[warn(deprecated)]` on by default
       >
       > warning: field `rx` is never read
       >    --> src/registry.rs:218:5
       >     |
       > 216 | pub struct NullGCRoots {
       >     |            ----------- field in this struct
       > 217 |     output: Output,
       > 218 |     rx: Option<GCRootsRx>,
       >     |     ^^
       >     |
       >     = note: `NullGCRoots` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
       >     = note: `#[warn(dead_code)]` on by default
       >
       > warning: `fc-userscan` (bin "fc-userscan") generated 2 warnings
       >     Finished release [optimized] target(s) in 15.83s
       > /nix/store/558iw5j1bk7z6wrg8cp96q2rx03jqj1v-stdenv-linux/setup: line 115: rst2man.py: command not found
       > /nix/store/558iw5j1bk7z6wrg8cp96q2rx03jqj1v-stdenv-linux/setup: line 131: pop_var_context: head of shell_variables not a function context
       For full logs, run 'nix log /nix/store/ax6f6072a3k9mcwmms1x48pn6jahin42-fc-userscan-0.4.8.drv'.
       ```

@osnyx osnyx force-pushed the PL-132430-percona-innovation branch from 29e769f to ae2d35e Compare May 8, 2024 09:03
@osnyx osnyx force-pushed the PL-132430-percona-innovation branch from ae2d35e to a984d4b Compare May 8, 2024 17:33
@osnyx osnyx force-pushed the PL-132430-percona-innovation branch 3 times, most recently from c78bb6b to 74f237b Compare May 22, 2024 18:32
osnyx added 5 commits May 22, 2024 23:50
Pull upstream NixOS changes, security fixes and package updates:

- awscli: 1.32.58 -> 1.32.101
- awscli: sync with botocore
- bind: 9.18.26 -> 9.18.27
- chromedriver: 124.0.6367.155 -> 125.0.6422.60
- chromedriver: 124.0.6367.91 -> 124.0.6367.155
- chromium: 124.0.6367.118 -> 125.0.6422.60
- chromium: prevent automatic Widevine DRM download
- chromium: rebase widevine patch for M125
- chromium: remove internal widevine drv in favor of `widevine-cdm`
- consul: 1.18.1 -> 1.18.2
- coreutils: Skip df/total-verify test
- curl: backport unreleased curl 8.7 bugfix
- gitlab-container-registry: 3.93.0 -> 4.1.0
- gitlab-runner: 16.11.0 -> 16.11.1
- gitlab: 16.10.4 -> 16.10.5
- imagemagick: 7.1.1-30 -> 7.1.1-32
- k3s: Add wrmilling as maintainer
- k3s: fix a blank space making update script not match nixfmt
- k3s: format with nixfmt-rfc-style
- k3s: k3s_1_29 -> k3s_1_30
- k3s: normalize alphabetical order in maintainers
- k3s: package k3s-killall script
- k3s: update update-script for nixfmt-rfc-style
- keycloak: 24.0.3 -> 24.0.4
- kubernetes-helm: 3.14.4 -> 3.15.0
- libressl: 3.9.1 -> 3.9.2
- libressl: backport to replace expiring certs
- linux_5_15: 5.15.158 -> 5.15.159
- nginxStable: 1.24.0 -> 1.26.0
- nss_latest: 3.99 -> 3.100
- opensearch: 2.13.0 -> 2.14.0
- openssh: build with correct passwd path
- pcre2: fix build for loongarch64
- pcre: Fetch patch for powerpc64-linux
- percona-xtrabackup_8_3: init at 8.3.0-1
- percona: adapt upstream release model
- percona: apply required multi-version package structure
- php82: 8.2.18 -> 8.2.19
- php83: 8.3.6 -> 8.3.7
- podman: 5.0.2 -> 5.0.3
- podman: Improve packaging
- poetry: 1.8.2 -> 1.8.3
- prometheus: 2.49.1 -> 2.52.0, (#310321)
- prosody: bump community modules to d3a72777f149 (#311078)
- qemu: 8.2.3 -> 8.2.4
- roundcube: 1.6.6 -> 1.6.7
- rsync: Make enableLZ4 and enableOpenSSL parameters work when set to false
- strace: 6.8 -> 6.9
- vim: 9.1.0200 -> 9.1.0377
- zip: add RossComputerGuy as maintainer

PL-132430

- also adjusts nginx tests to the nex expected version number
Prepares to offer the LTS and Innovation releases from upstream in
parallel, while creating version-pinned attributes.

PL-132430
is end of life and we drop support for it
Ta better handle the growing number of supported percona releases, the list of supported (modern)
percona versions only needs to be declared once, with all other derived declarations being autogenerated.
@osnyx osnyx force-pushed the PL-132430-percona-innovation branch from 74f237b to 60d983c Compare May 22, 2024 21:51
@osnyx osnyx changed the title WIP: adapting to new percona release scheme [24.05] percona: adapt to new release scheme; update nixpkgs May 22, 2024
@osnyx osnyx marked this pull request as ready for review May 22, 2024 22:11
@dpausp dpausp merged commit 5da77a6 into pre-fc-24.05 May 28, 2024
1 of 2 checks passed
@dpausp dpausp deleted the PL-132430-percona-innovation branch May 28, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants