Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always restart gitlab-mailroom #1048

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

laalsaas
Copy link
Collaborator

@laalsaas laalsaas commented Jul 2, 2024

PL-131890

@flyingcircusio/release-managers

Release process

Impact:

Changelog:

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • This should make incoming mail on gitlab more reliable, so problems like the one in the ticket don't occur.
  • Security requirements tested? (EVIDENCE)
    • ran the gitlab test locally, with a slightly modified config to activate the gitlab-mailroom service
    • verified that it was restarted multiple times

nixos/roles/gitlab.nix Outdated Show resolved Hide resolved
nixos/roles/gitlab.nix Outdated Show resolved Hide resolved
@dpausp dpausp merged commit 91818f0 into fc-24.05-dev Jul 5, 2024
2 checks passed
@dpausp dpausp deleted the PL-131890-gitlab-mailroom-restart-always branch July 5, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants