Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images.fc: fix opening with kernel 5.15 #1049

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

osnyx
Copy link
Member

@osnyx osnyx commented Jul 3, 2024

We're still using kernel 5.15 in our VMs for now. Opening the XFS from the VM image had failed due to incompatible XFS features.

nrext64 is only availabe from 5.19 on and non-experimental since 6.5, so we need to explicitly disable that feature for now when writing images.

PL-132780

@flyingcircusio/release-managers

Release process

Impact: -

Changelog: -

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • image file system needs to be mountable by the VM kernel at bootstrap
    • must not introduce known regressions
  • Security requirements tested? (EVIDENCE)
    • automated tests still pass
    • successfully mounted the image from a running 24.05 VM
      • as bootstrapping was broken all the time so far, I refrain from explicitly testing a bootstrap from this PR built product image and will do that once it has reached dev. I'm certain to have identified, tested and corrected the underlying issue.

We're still using kernel 5.15 in our VMs for now. Opening the XFS from
the VM image had failed due to incompatible XFS features.

`nrext64` is only availabe from 5.19 on and non-experimental since 6.5,
so we need to explicitly disable that feature for now when writing
images.
@osnyx osnyx marked this pull request as ready for review July 3, 2024 15:29
@dpausp dpausp merged commit e4b5a68 into fc-24.05-dev Jul 4, 2024
2 checks passed
@dpausp dpausp deleted the PL-132780-image-bootstrap branch July 4, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants