Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22.05] openssh: use 9.6p1 by default, patched against CVE-2024-6387 #1053

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

osnyx
Copy link
Member

@osnyx osnyx commented Jul 5, 2024

@flyingcircusio/release-managers

Package openssh-9.6p1 with patches against CVE-2024-6387 and use it as new platform default.

PL-132768

Release process

Impact: sshd.service will be restarted

Changelog:

  • openssh: apply patches for GHSA-2x8c-95vh-gfv4, default package used changes 9.0p1 -> 9.6p1
    • fixes a remote code execution vulnerability https://www.qualys.com/2024/07/01/cve-2024-6387/regresshion.txt
    • additionally also backport a fix for a minor logic error in ObscureKeystrokeTiming
    • note that this only updates the openssh_9_6 package, which is used by the in-path ssh command and the sshd.service of the platform
    • This might affect the defaults for cryptographic algorithms, see the openssh release notes for details

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

@dpausp dpausp merged commit c47ce3b into fc-22.05-dev Jul 5, 2024
2 checks passed
@dpausp dpausp deleted the PL-132768-2205 branch July 5, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants