Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.05] nixpkgs: fix revision to latest one from nixos-21.05 branch again #1057

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

osnyx
Copy link
Member

@osnyx osnyx commented Jul 5, 2024

We accidentally locked an intermediate result while rebasing. The content of the old and new revision is semantically identical.

@flyingcircusio/release-managers

Release process

Impact:

Changelog:

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • availability of code: pick a revision that is part of a git branch to prevent accidental garbage collection
    • investigate weirdly looking git histories
    • must not introduce any known regressions
  • Security requirements tested? (EVIDENCE)
    • automated tests still pass

We accidentally locked an intermediate result while rebasing. The
content of the old and new revision is semantically identical.
@osnyx osnyx changed the title nixpkgs: fix revision to latest one from nixos-21.05 branch again [21.05] nixpkgs: fix revision to latest one from nixos-21.05 branch again Jul 5, 2024
@dpausp dpausp merged commit 6d11975 into fc-21.05-dev Jul 5, 2024
2 checks passed
@dpausp dpausp deleted the PL-132775 branch July 5, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants