Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k3s: use 1.30 for new systems (state version 24.05) #1058

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

dpausp
Copy link
Member

@dpausp dpausp commented Jul 5, 2024

Current systems have a state version older than 24.05. They get the same k3s as for NixOS 23.11. New systems (or systems with an manually updated state version) get the current default version, that is 1.30

PL-132671

@flyingcircusio/release-managers

Release process

Impact:

Changelog:

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • use current versions for k3s for new machines
    • allow smooth upgrades from older platform versions by pinning the k3s version to the same as for 23.11
  • Security requirements tested? (EVIDENCE)
    • automated k3s test still runs, upgraded test cluster and checked that the version of k3s has not changed

@dpausp dpausp force-pushed the PL-132671-k3s-version-by-state-version branch from 1e82c42 to 722f85d Compare July 5, 2024 14:21
Current systems have a state version older than 24.05. They get the same
k3s as for NixOS 23.11. New systems (or systems with an manually updated state
version) get the current default version, that is 1.30

PL-132671
@dpausp dpausp force-pushed the PL-132671-k3s-version-by-state-version branch from 722f85d to b76f15e Compare July 5, 2024 17:26
@dpausp dpausp requested a review from osnyx July 5, 2024 18:30
Copy link
Member

@osnyx osnyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and testing plan looks good, approving on the condition of successful actual testing results.

@dpausp dpausp marked this pull request as ready for review July 6, 2024 18:20
@dpausp dpausp merged commit 892a3b4 into fc-24.05-dev Jul 6, 2024
2 checks passed
@dpausp dpausp deleted the PL-132671-k3s-version-by-state-version branch July 6, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants