Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of VNMaxPooling #5

Closed
tranluan opened this issue Jun 24, 2021 · 1 comment
Closed

Implementation of VNMaxPooling #5

tranluan opened this issue Jun 24, 2021 · 1 comment

Comments

@tranluan
Copy link

Hi @FlyingGiraffe,
In the maxpooling implementation, at this line:

idx = dotprod.max(dim=-1, keepdim=False)[1]

In order to get the indices idx, are we suppose to use argmax instead of max operation?

@FlyingGiraffe
Copy link
Owner

The output of the max function is a tuple of (values, indices) - in some later pytorch versions. If you're using an earlier version it may not return the indices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants