Adding F flag to make links pdf/a-1a conform #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asolntsev
approved these changes
Mar 7, 2024
|
@haramon Released FlyingSaucer 9.6.0. Thank you for the contribution! P.S. Probably we should add VeraPDF to test dependencies, and validate all generated PDFs? |
|
Thanks, for the fast review and release 👍 Yeah, it would be convenient to cover the veraPDF validation with tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flying Saucer is not generating links from a tags that are PDF/A-1A conform:
<a href="https://www.google.at/">My link</a>The veraPDF validation`of Rule 6.5.3-2 fails with following error:
An annotation dictionary shall contain the F key. The F key's Print flag bit shall be set to 1 and its Hidden, Invisible and NoView flag bits shall be set to 0.This fix adds the
Fkey to the annotation of generated links, so the pdf passes the PDF/A-1A conformity check.If the fix is acceptable, it would be nice to have a release soon. If version 9.6.0 cannot be released yet, it is also ok cherry-picking this commit to 9.5.2 and release from there.
Thanks for your time :)