Merge pull request #3112 from slurms/validate_env_vars_before_release

cli: prevent empty environment variable keys
flynn · Jul 13, 2016 · 228cb2e · 228cb2e
2 parents d2ac28d + d3c60a4
commit 228cb2e
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/controller/release.go b/controller/release.go
@@ -63,6 +63,13 @@ func (r *ReleaseRepo) Add(data interface{}) error {
 		release.ArtifactIDs = []string{release.LegacyArtifactID}
 	}
 
+	if value, ok := release.Env[""]; ok {
+		return ct.ValidationError{
+			Field:   "env",
+			Message: fmt.Sprintf("you can't create an env var with an empty key (tried to set \"\"=%q)", value),
+		}
+	}
+
 	tx, err := r.db.Begin()
 	if err != nil {
 		return err