This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
controller: Add cluster backup endpoint #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| if err := tw.WriteJSON("flynn.json", data); err != nil { | ||
| if err := clusterbackup.RunBackup(client, dest); err != nil { |
There was a problem hiding this comment.
I think the package should be backup and the function Run, so this becomes backup.Run, WDYT?
There was a problem hiding this comment.
Yeah, that's simpler.
|
Is it worth adding a test for this? Hit |
|
jvatic
force-pushed
the
controller-backup
branch
from
97ef5a6
to
e2e4bbd
Compare
|
@lmars comments addressed |
jvatic
force-pushed
the
controller-backup
branch
from
e2e4bbd
to
a5a26f8
Compare
|
jvatic
force-pushed
the
controller-backup
branch
from
a5a26f8
to
ee5ef3a
Compare
- Cluster backup logic is now in pkg/clusterbackup - `GET /backup` responds with a tar file (same as `flynn cluster backup`) Signed-off-by: Jesse Stuart <jesse@jessestuart.ca>
jvatic
force-pushed
the
controller-backup
branch
from
ee5ef3a
to
6d9ee3e
Compare
Signed-off-by: Jesse Stuart <jesse@jessestuart.ca>
jvatic
force-pushed
the
controller-backup
branch
from
6d9ee3e
to
a91ee59
Compare
|
LGTM |
jvatic
added a commit
that referenced
this pull request
Dec 7, 2015
controller: Add cluster backup endpoint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2095