This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
pkg/status: Return version in status #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| func New(healthy bool, detail interface{}) (Status, error) { | ||
| var s Status | ||
| s.Version = version.String() |
There was a problem hiding this comment.
Any reason to assign this here? The assignment in the handler should be sufficient.
Signed-off-by: Joseph Glanville <jpg@jpg.id.au>
josephglanville
force-pushed
the
status_versions
branch
from
69273ba
to
85ac808
Compare
|
LGTM |
josephglanville
added a commit
that referenced
this pull request
Nov 29, 2015
pkg/status: Return version in status
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joseph Glanville jpg@jpg.id.au