This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
scheduler: Fix test races #2961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a formation change happens, jobs are started and stopped in goroutines which means there is no guarantee the tests will get formation events before job events. In most cases, the test just cares that a job event occurs. The fact that it is due to a formation change is irrelevant, so there is no need to explicitly wait for the formation event. Signed-off-by: Lewis Marshall <lewis@lmars.net>
TestMultipleHosts starts and stops jobs whilst the scheduler is paused and then relies on the scheduler seeing the started job before the stopped one. This is so that the number of jobs involved is predictable (if the scheduler sees the stopped job first, it starts a replacement job, then sees another job started and kills the one it just started). Since the scheduler has a goroutine per host, there is no guarantee which goroutine will handle it's event first, so a hook has been added to ensure the event from AddJob has made it to the scheduler before returning. Signed-off-by: Lewis Marshall <lewis@lmars.net>
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages, hopefully fixes the recent flakiness in CI.