This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
host/logmux: Add timeouts to sink writes #4485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These basic timeouts prevent a potential scenario where the stdout pipe from a container fills up due to a blocked sink, in turn blocking the containerized process in a write(2) to the pipe. Signed-off-by: Jonathan Rudenberg <jonathan@titanous.com>
lmars
approved these changes
Nov 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These basic timeouts prevent a potential scenario where the stdout pipe from a container fills up due to a blocked sink, in turn blocking the containerized process in a write(2) to the pipe.
Both timeouts were tested manually via code modifications due to the complexity and fragility of an integration test for these paths.