This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
controller: Add in-batches deploy strategy #4567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lewis Marshall <lewis@lmars.net>
ghost
reviewed
Nov 30, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
Signed-off-by: Lewis Marshall <lewis@lmars.net>
|
The original changeset missed the requirement that this should support a configurable batch size rather than just the number of hosts. Given that, in fa56f82 I have:
If the batch size is not set explicitly, then the deployment will behave as originally implemented (i.e. use the host count as the batch size). @titanous ready for review. |
lmars
changed the title
titanous
reviewed
Dec 9, 2019
Signed-off-by: Lewis Marshall <lewis@lmars.net>
titanous
approved these changes
Dec 30, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
one-per-hostdeployment strategy that is similar to aone-by-onedeployment but scales one job per host at each step of the deploy.The actual strategy just scales in batches equal to the host count and relies on the scheduler distributing the jobs evenly across the hosts in the cluster to effectively scale one per host.
Ref #3010.