This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
controller: Don't allow artifact type or uri to be empty strings and fix validation error responses #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case ct.ValidationError: | ||
| detail := map[string]string{"field": v.Field} | ||
| raw, _ := json.Marshal(detail) | ||
| rawMessage := json.RawMessage(raw) |
There was a problem hiding this comment.
This step should be unnecessary.
jvatic
force-pushed
the
controller-fix
branch
3 times, most recently
from
67c4388
to
5609c07
Compare
|
@titanous comments addressed |
Signed-off-by: Jesse Stuart <jesse@jessestuart.ca>
Also prevents creating a formation using such a release Signed-off-by: Jesse Stuart <jesse@jessestuart.ca>
Signed-off-by: Jesse Stuart <jesse@jessestuart.ca>
jvatic
force-pushed
the
controller-fix
branch
from
5609c07
to
9e119a4
Compare
| in.Type = "docker" | ||
| } | ||
| if in.URI == "" { | ||
| in.URI = fmt.Sprintf("https://example.com/%d", time.Now().Unix()) |
There was a problem hiding this comment.
Use a random string generated by pkg/random
jvatic
force-pushed
the
controller-fix
branch
from
9e119a4
to
8699c1c
Compare
Signed-off-by: Jesse Stuart <jesse@jessestuart.ca>
jvatic
force-pushed
the
controller-fix
branch
from
8699c1c
to
767a6af
Compare
|
LGTM |
jvatic
added a commit
that referenced
this pull request
Jan 26, 2015
controller: Don't allow artifact type or uri to be empty strings and fix validation error responses
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.