This repository has been archived by the owner on Apr 30, 2020. It is now read-only.
Before & After Actions #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 27, 2018 10:36
- includes additional test
- includes small refactor of protected functions to make timing work - includes additional test
|
@domtra seems there's something wrong with a dependency in one of the travis tests: https://travis-ci.org/flyntwp/flynt-core/jobs/397247418 |
|
@Qakulukiam have you tried adding the min stability and prefer stable properties in the composer.json? |
|
No, since I didn't change anything composer related I expected it to still work.. I'll try adding your proposed solution. |
usingthesystem
approved these changes
Jun 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added before and after actions to BuildConstructionPlan and Render. We can use this for logging and performance monitoring (and maybe more) in the future.