Ashanti/optimize print styles #236
Conversation
…styles for front page, not finished yet
…styles for front page, not finished yet
…, fixed different height
assets/admin.scss
Outdated
| @@ -4,3 +4,5 @@ | |||
|
|
|||
| // stylelint-disable-next-line scss/at-import-no-partial-leading-underscore, scss/at-import-partial-extension-blacklist | |||
| @import '../Components/**/_admin.scss'; | |||
|
|
|||
| @import 'styles/print'; | |||
There was a problem hiding this comment.
I don't think we need to have the print styles in the admin sheet.
assets/styles/_print.scss
Outdated
| [is='flynt-navigation-footer'], | ||
| [is="flynt-block-cookie-notice"], | ||
| .button, | ||
| footer { |
There was a problem hiding this comment.
Instead of hiding individual components, I would suggest to hide the wrapping sections of the layout: .mainHeader, .mainFooter, .wpFooter.
Also, I think buttons should still be visible and not every footer element should be hidden, as it might be used differently in a context where you want it to be visible.
assets/styles/_print.scss
Outdated
| display: none !important; | ||
| } | ||
|
|
||
| a { |
There was a problem hiding this comment.
I noticed this one is not having the :visited state that the HTML5 Boilerplate suggests. Why?
There was a problem hiding this comment.
I thought that this rule for the tag will apply to every tag on the page, if a:visited will get underlined, it will anyways get underlined, cause it is an tag. But obviously my thoughts were wrong due to your question.
assets/styles/_print.scss
Outdated
|
|
||
| a { | ||
| text-decoration: underline; | ||
| font-weight: bold; |
There was a problem hiding this comment.
Why make links bold? I believe they should look like in the design, but black and underlined.
There was a problem hiding this comment.
okay,removed it.
assets/styles/_print.scss
Outdated
| content: " (" attr(href) ")"; | ||
| } | ||
|
|
||
| a[href^="/"]:after { |
There was a problem hiding this comment.
I assume this would not show the urls of internal links, right? Why should we hide those?
There was a problem hiding this comment.
Was something I found when searching for print styles on the web. I removed it.
…t into ashanti/OptimizePrintStyles
|
I added some rules to the |
I did this without @media only screen, unfortunately i lost my notes about it. But this might be a good global approach.